vm restart issue 2

Author: Srivastava, Piyush

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/lifecycle/OntapPrimaryDatastoreLifecycle.java

@@ -291,7 +291,7 @@ public boolean attachCluster(DataStore dataStore, ClusterScope scope) {
                 _storageMgr.connectHostToSharedPool(host, dataStore.getId());
             } catch (Exception e) {
                 logger.warn("Unable to establish a connection between " + host + " and " + dataStore, e);
-                throw new CloudRuntimeException("Failed to attach storage pool to cluster: " + e.getMessage(), e);
+                return false;
             }
         }
         _dataStoreHelper.attachCluster(dataStore);
@@ -328,7 +328,7 @@ public boolean attachZone(DataStore dataStore, ZoneScope scope, Hypervisor.Hyper
                 _storageMgr.connectHostToSharedPool(host, dataStore.getId());
             } catch (Exception e) {
                 logger.warn("Unable to establish a connection between " + host + " and " + dataStore, e);
-                throw new CloudRuntimeException("Failed to attach storage pool to host: " + e.getMessage(), e);
+                return  false;
             }
         }
         _dataStoreHelper.attachZone(dataStore);

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/listener/OntapHostListener.java

@@ -77,6 +77,7 @@ public boolean hostConnect(long hostId, long poolId)  {
             logger.info("Host {} is already connected to storage pool {} at path {}. Skipping reconnection.", host.getName(), pool.getName(), existingConnection.getLocalPath());
             return true;
         }
+
         logger.info("Connecting host {} to ONTAP storage pool {}", host.getName(), pool.getName());
         try {
             // Create the ModifyStoragePoolCommand to send to the agent

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/service/UnifiedNASStrategy.java

@@ -372,16 +372,16 @@ private ExportPolicy createExportPolicyRequest(AccessGroup accessGroup,String sv
             String ip = (hostStorageIp != null && !hostStorageIp.isEmpty())
                     ? hostStorageIp
                     : host.getPrivateIpAddress();
-            String ipToUse = ip + "/31"; // TODO since we have 2 IPs internal and external
+            String ipToUse = ip + "/32";
             ExportRule.ExportClient exportClient = new ExportRule.ExportClient();
             exportClient.setMatch(ipToUse);
             exportClients.add(exportClient);
         }
         exportRule.setClients(exportClients);
         exportRule.setProtocols(List.of(ExportRule.ProtocolsEnum.any));
-        exportRule.setRoRule(List.of("any"));
-        exportRule.setRwRule(List.of("any"));
-        exportRule.setSuperuser(List.of("any")); // Allow root/superuser access for NFS writes
+        exportRule.setRoRule(List.of("sys")); // Use sys (Unix UID/GID) authentication for NFS
+        exportRule.setRwRule(List.of("sys")); // Use sys (Unix UID/GID) authentication for NFS
+        exportRule.setSuperuser(List.of("sys")); // Allow root/superuser access with sys auth
         rules.add(exportRule);
 
         Svm svm = new Svm();