CSTACKEX-18_2: rollback the object creation in case of failures

Author: rajiv-jain-netapp

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/vmsnapshot/OntapVMSnapshotStrategy.java

@@ -272,6 +272,15 @@ public VMSnapshot takeVMSnapshot(VMSnapshot vmSnapshot) {
                     "Please use snapshotmemory=false for disk-only snapshots.",
                     userVm.getInstanceName());
             logger.error("takeVMSnapshot: {}", errorMsg);
+            // Clean up the VM snapshot record that was created in Allocated state before throwing
+            // This prevents orphaned snapshot records from showing in the UI
+            try {
+                vmSnapshotDao.remove(vmSnapshotVO.getId());
+                logger.debug("takeVMSnapshot: Removed VM snapshot record [{}] after memory snapshot validation failure", vmSnapshotVO.getId());
+            } catch (Exception cleanupEx) {
+                logger.warn("takeVMSnapshot: Failed to remove VM snapshot record [{}] during cleanup: {}",
+                        vmSnapshotVO.getId(), cleanupEx.getMessage());
+            }
             throw new CloudRuntimeException(errorMsg);
         }