vm instance creation test8

Author: Srivastava, Piyush

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

@@ -147,23 +147,30 @@ private String createCloudStackVolumeForTypeVolume(DataStore dataStore, DataObje
             // CRITICAL: Set poolType at VOLUME level
             // This tells KVM to use LibvirtStorageAdaptor (NFS) instead of IscsiAdmStorageAdaptor
             volume.setPoolType(Storage.StoragePoolType.NetworkFilesystem);
-            // For managed NFS with subdirectories, set path to point to file INSIDE the subdirectory
-            // Path format: ROOT-17_5d11c615.../5d11c615...
-            // Full path on KVM will be: /mnt/{pool-uuid}/ROOT-17_5d11c615.../5d11c615....qcow2
-            // The subdirectory already exists (created by ONTAP), qemu-img will create the file inside
+            // For managed NFS with subdirectories, point to file INSIDE the subdirectory
+            // Path format: subdirectory/uuid (e.g., ROOT-20_85969d09.../85969d09...)
             String volumePath = subdirectoryName + "/" + volumeUuid;
             volume.setPath(volumePath);
+            // CRITICAL FIX: Also update the volume NAME to the full path
+            // This is what KVM LibvirtStorageAdaptor uses when creating the physical disk
+            // Without this, KVM uses just the original volume name (ROOT-20) instead of the path
+            volume.setName(volumePath);
             // Set _iScsiName to subdirectory path for managed storage tracking
-            // This field is used during cleanup operations
             volume.set_iScsiName(subdirectoryName);
             volume.setFolder(volumeUuid);  // Store UUID in folder field
             volume.setPoolId(dataStore.getId());
             volumeDao.update(volume.getId(), volume);
-            // Re-read from database to confirm the path was saved correctly
+            // Re-read from database to verify the changes
             VolumeVO updatedVolume = volumeDao.findById(volume.getId());
-            s_logger.info("createCloudStackVolumeForTypeVolume: NFS subdirectory '{}' created on ONTAP", subdirectoryName);
-            s_logger.info("createCloudStackVolumeForTypeVolume: Volume {} - Path set to: {}, _iScsiName: {}, Folder: {}, PoolType: {}", updatedVolume.getName(), updatedVolume.getPath(), updatedVolume.get_iScsiName(), updatedVolume.getFolder(), updatedVolume.getPoolType());
-            return null;  // Return null - hypervisor will create the qcow2 file inside the subdirectory
+            s_logger.info("=== ONTAP NFS Volume Configuration ===");
+            s_logger.info("Subdirectory created: {}", subdirectoryName);
+            s_logger.info("Volume Name: {} (THIS IS WHAT KVM USES)", updatedVolume.getName());
+            s_logger.info("Volume Path: {}", updatedVolume.getPath());
+            s_logger.info("Volume _iScsiName: {}", updatedVolume.get_iScsiName());
+            s_logger.info("Volume Folder: {}", updatedVolume.getFolder());
+            s_logger.info("Volume PoolType: {}", updatedVolume.getPoolType());
+            s_logger.info("======================================");
+            return null;  // Return null - hypervisor will create qcow2 file inside subdirectory
         }
         // For iSCSI and other protocols, use ONTAP REST API
         StorageStrategy storageStrategy = getStrategyByStoragePoolDetails(details);