Shadows on water surfaces#1965
Open
AdamTadeusz wants to merge 5 commits into
Open
Conversation
AdamTadeusz
added
the
Changes in neoAssets
DESTROYGIRL
approved these changes
May 21, 2026
Contributor
DESTROYGIRL
left a comment
DESTROYGIRL
left a comment
There was a problem hiding this comment.
Looks good, didn't seem to create issues for existing materials, tested on rogue:
Comment on lines
+270
to
+272
| #else // Still custom NEO code | ||
| SET_STATIC_PIXEL_SHADER_COMBO(LIGHTMAPWATERFOG, 0); | ||
| #endif // NEO |
Contributor
There was a problem hiding this comment.
Was a lil confused by this until I realised it's because we can't #ifdef stuff in the shader code correct?
I don't think I was mindful of that when changing lightmappedgeneric. I wonder if it's the correct thing to do or we should just pull the original shader sources if you want to do a non-NEO build?
Contributor
Author
There was a problem hiding this comment.
that was the thought process yes. And you're probably right, if anyone is building without the NEO define for whatever reason they should just pull the original shaders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
neo assets pr NeotokyoRebuild/neoAssets#120
Adds support for the $lightmapwaterfog water texture param used in games post l4d2. I wasn't able to get the scale to which the shadow is applied to the fog colour, so I made it depend on the alpha value of the water fog colour.
Keep in mind, water with this parameter needs to have a lightmap. Depending on the bsp compiler used, setting $lightmapwaterfog before compiling may be enough, or you may have to add a compiler flag like "%compileKeepLight". You can check if a water surface has a lightmap with the mat_luxels 1 command. If the surface is entirely filled in in blue, there is no lightmap. If instead you can see a square grid pattern corresponding to the lightmap resolution, the water has a lightmap.
Some example images
$lightmapwaterfog 0
$lightmapwaterfog 1 $fogcolor" "{52 49 44 0}
$lightmapwaterfog 1 $fogcolor" "{52 49 44 1}
Toolchain