Skip to content

Commit 9505d56

Browse files
committed
fixes for ios and other stuff
1 parent 32eadd6 commit 9505d56

File tree

8 files changed

+17
-11
lines changed

8 files changed

+17
-11
lines changed

examples/appkit.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ export class Window extends NSWindow {
100100
label.editable = false;
101101
label.selectable = false;
102102
label.alignment = NSTextAlignment.center;
103-
label.setTranslatesAutoresizingMaskIntoConstraints(false);
103+
label.translatesAutoresizingMaskIntoConstraints = false;
104104
label.textColor = NSColor.colorWithSRGBRedGreenBlueAlpha(1, 1, 1, 1);
105105

106106
label.font = NSFontManager.sharedFontManager.convertFontToHaveTrait(
@@ -118,7 +118,7 @@ export class Window extends NSWindow {
118118
vstack.alignment = NSLayoutAttribute.centerX;
119119
vstack.distribution = NSStackViewDistribution.fill;
120120
vstack.spacing = 40;
121-
vstack.setTranslatesAutoresizingMaskIntoConstraints(false);
121+
vstack.translatesAutoresizingMaskIntoConstraints = false;
122122

123123
const imageURL = NSString.stringWithUTF8String(
124124
new URL("../assets/NativeScript.png", import.meta.url).pathname,

examples/split_view.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ export class SidebarViewController extends NSViewController {
104104
scrollView.hasHorizontalScroller = false;
105105
scrollView.documentView = outline;
106106
scrollView.drawsBackground = false;
107-
scrollView.setTranslatesAutoresizingMaskIntoConstraints(false);
107+
scrollView.translatesAutoresizingMaskIntoConstraints = false;
108108

109109
this.view = scrollView;
110110
}
@@ -194,7 +194,7 @@ export class ContentViewController extends NSViewController {
194194
label.editable = false;
195195
label.selectable = false;
196196
label.alignment = 1 /* NSTextAlignmentCenter */;
197-
label.setTranslatesAutoresizingMaskIntoConstraints(false);
197+
label.translatesAutoresizingMaskIntoConstraints = false;
198198
label.textColor = NSColor.colorWithSRGBRedGreenBlueAlpha(1, 1, 1, 1);
199199

200200
label.font = NSFontManager.sharedFontManager.convertFontToHaveTrait(
@@ -214,7 +214,7 @@ export class ContentViewController extends NSViewController {
214214
vstack.alignment = 9 /* NSLayoutAttributeCenterX */;
215215
vstack.distribution = 0 /* NSStackViewDistributionFill */;
216216
vstack.spacing = 40;
217-
vstack.setTranslatesAutoresizingMaskIntoConstraints(false);
217+
vstack.translatesAutoresizingMaskIntoConstraints = false;
218218

219219
const imageURL = NSString.stringWithUTF8String(
220220
new URL("../assets/NativeScript.png", import.meta.url).pathname,

examples/view_controller.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ export class ViewController extends NSViewController {
7878
label.editable = false;
7979
label.selectable = false;
8080
label.alignment = NSTextAlignment.center;
81-
label.setTranslatesAutoresizingMaskIntoConstraints(false);
81+
label.translatesAutoresizingMaskIntoConstraints = false;
8282
label.textColor = NSColor.colorWithSRGBRedGreenBlueAlpha(1, 1, 1, 1);
8383
label.font = NSFontManager.sharedFontManager.convertFontToHaveTrait(
8484
NSFont.fontWithNameSize(label.font.fontName, 45),
@@ -95,7 +95,7 @@ export class ViewController extends NSViewController {
9595
vstack.alignment = NSLayoutAttribute.centerX;
9696
vstack.distribution = NSStackViewDistribution.fill;
9797
vstack.spacing = 40;
98-
vstack.setTranslatesAutoresizingMaskIntoConstraints(false);
98+
vstack.translatesAutoresizingMaskIntoConstraints = false;
9999

100100
const imageURL = NSString.stringWithUTF8String(
101101
new URL("../assets/NativeScript.png", import.meta.url).pathname,
@@ -114,7 +114,7 @@ export class ViewController extends NSViewController {
114114
button.controlSize = NSControlSize.large;
115115
button.bezelStyle = NSBezelStyle.rounded;
116116
button.setButtonType(NSButtonType.momentaryLight);
117-
button.setTranslatesAutoresizingMaskIntoConstraints(false);
117+
button.translatesAutoresizingMaskIntoConstraints = false;
118118

119119
this.button = button;
120120

metadata/metadata.ios.nsmd

1.48 KB
Binary file not shown.

metadata/metadata.macos.nsmd

-411 Bytes
Binary file not shown.

src/CustomClass.mm

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
#include "Closure.h"
22
#include "ObjCBridgeData.h"
33
#include "Util.h"
4+
#import <Foundation/Foundation.h>
45

56
namespace objc_bridge {
67

src/Object.mm

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,12 @@ napi_value findConstructorForObject(napi_env env, ObjCBridgeData *bridgeData,
184184
unregisterObject(obj);
185185
}
186186

187+
auto cls = object_getClass(obj);
188+
auto mdFindByPointer = mdClassesByPointer.find(cls);
189+
if (mdFindByPointer != mdClassesByPointer.end()) {
190+
classOffset = mdFindByPointer->second;
191+
}
192+
187193
napi_value constructor = nullptr;
188194
if (classOffset != 0) {
189195
auto bridgedCls = getClass(env, classOffset);
@@ -202,7 +208,7 @@ napi_value findConstructorForObject(napi_env env, ObjCBridgeData *bridgeData,
202208

203209
constructor = get_ref_value(env, proto->constructor);
204210
} else {
205-
constructor = findConstructorForObject(env, this, obj);
211+
constructor = findConstructorForObject(env, this, obj, cls);
206212
}
207213

208214
if (constructor == nullptr) {

src/Protocol.mm

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@
6363
napi_value constructor, prototype;
6464
napi_define_class(env, name.c_str(), NAPI_AUTO_LENGTH, JS_ProtocolConstructor,
6565
nullptr, 0, nullptr, &constructor);
66+
napi_wrap(env, constructor, this, nullptr, nullptr, nullptr);
6667

6768
napi_get_named_property(env, constructor, "prototype", &prototype);
6869

@@ -85,8 +86,6 @@
8586
napi_inherits(env, constructor, protoValue);
8687
}
8788

88-
napi_wrap(env, constructor, this, nullptr, nullptr, nullptr);
89-
9089
next = true;
9190

9291
while (next) {

0 commit comments

Comments
 (0)