fix: framework not removed if only referenced from removed target

Author: KristianDD

lib/pbxProject.js

@@ -1677,10 +1677,13 @@ pbxProject.prototype.removeTargetsByProductType = function(targetProductType) {
 
 pbxProject.prototype.removeTarget = function(target, targetKey) {
     let files = [];
+    var pbxBuildFileSection = this.pbxBuildFileSection();
+    var fileReferenceSection = this.pbxFileReferenceSection();
 
     // iterate all buildPhases and collect all files that should be removed
     // remove the phase from the appropriate section
     var buildPhases = target["buildPhases"];
+
     for (let i = 0; i < buildPhases.length; i++) {
         var buildPhase = buildPhases[i];
         var sectionUuid = buildPhase.value;
@@ -1693,7 +1696,26 @@ pbxProject.prototype.removeTarget = function(target, targetKey) {
             files = files.concat(section[sectionUuid].files);
         } else if (buildPhase.comment === buildPhaseNameForIsa("PBXFrameworksBuildPhase")) {
             section = this.hash.project.objects["PBXFrameworksBuildPhase"];
-            files = files.concat(section[sectionUuid].files);
+            var frameworkFiles = section[sectionUuid].files;
+            for (let q = 0; q < frameworkFiles.length; q++) {
+                var currentBuildFileUuid = frameworkFiles[q].value;
+                var fileRef = pbxBuildFileSection[currentBuildFileUuid].fileRef;
+                var stillReferenced = false;
+                for (var buildFileUuid in nonComments(pbxBuildFileSection)) {
+                    if(pbxBuildFileSection[buildFileUuid].fileRef === fileRef && buildFileUuid !== currentBuildFileUuid){
+                        stillReferenced = true;
+                    }
+                }
+
+                if(!stillReferenced) {
+                    var frameworkFileRef = fileReferenceSection[fileRef];
+                    var fileToRemove = new pbxFile(unquote(frameworkFileRef.path), {basename: frameworkFileRef.name});
+                    fileToRemove.fileRef = fileRef;
+                    this.removeFromFrameworksPbxGroup(fileToRemove);
+                    removeItemAndCommentFromSectionByUuid(fileReferenceSection, fileRef);
+                }
+            }
+            files = files.concat(frameworkFiles);
         }
 
         removeItemAndCommentFromSectionByUuid(section, sectionUuid);
@@ -1734,12 +1756,10 @@ pbxProject.prototype.removeTarget = function(target, targetKey) {
     var productUuid = "";
 
     var productReferenceUuid = target.productReference;
-    var pbxBuildFileSection = this.pbxBuildFileSection();
-    var pbxBuildFileSectionNoComments = nonComments(pbxBuildFileSection);
 
     // the productReference is the uuid from the PBXFileReference Section, but we need the one in PBXBuildFile section
     // check the fileRef of all records until we find the product
-    for (var uuid in pbxBuildFileSectionNoComments) {
+    for (var uuid in nonComments(pbxBuildFileSection)) {
         if (this.pbxBuildFileSection()[uuid].fileRef == productReferenceUuid) {
             productUuid = uuid;
         }
@@ -1787,7 +1807,6 @@ pbxProject.prototype.removeTarget = function(target, targetKey) {
 
 
     //remove the product from the Products PBXGroup
-    var fileReferenceSection = this.pbxFileReferenceSection();
     var productReference = fileReferenceSection[productReferenceUuid];
     var productFile = new pbxFile(productReference.path);
     productFile.fileRef = productReferenceUuid;