fix: ensure temp files are deleted

Ensure the temp files created by nativescript-doctor are deleted

Author: rosen-vladimirov

lib/sys-info.ts

@@ -275,11 +275,15 @@ export class SysInfo implements NativeScriptDoctor.ISysInfo {
 				try {
 					const spawnResult = await this.childProcess.spawnFromEvent("pod", ["install"], "exit", { spawnOptions: { cwd: xcodeProjectDir } });
 					if (spawnResult.exitCode) {
+						this.fileSystem.deleteEntry(tempDirectory);
 						return false;
 					} else {
-						return this.fileSystem.exists(path.join(xcodeProjectDir, "cocoapods.xcworkspace"));
+						const exists = this.fileSystem.exists(path.join(xcodeProjectDir, "cocoapods.xcworkspace"));
+						this.fileSystem.deleteEntry(tempDirectory);
+						return exists;
 					}
 				} catch (err) {
+					this.fileSystem.deleteEntry(tempDirectory);
 					return null;
 				}
 			} else {

lib/wrappers/file-system.ts

@@ -2,6 +2,7 @@ import * as fs from "fs";
 import * as path from "path";
 import * as yauzl from "yauzl";
 import * as util from "util";
+import * as shelljs from "shelljs";
 
 const access = util.promisify(fs.access);
 const mkdir = util.promisify(fs.mkdir);
@@ -58,6 +59,10 @@ export class FileSystem {
 		const content = fs.readFileSync(filePath, options);
 		return JSON.parse(content.toString());
 	}
+
+	public deleteEntry(filePath: string): void {
+		shelljs.rm("-rf", filePath);
+	}
 }
 
 function createParentDirsIfNeeded(filePath: string) {

package.json

@@ -28,6 +28,7 @@
     "@types/mocha": "2.2.32",
     "@types/rimraf": "2.0.2",
     "@types/semver": "5.5.0",
+    "@types/shelljs": "0.8.6",
     "@types/temp": "0.8.29",
     "@types/winreg": "1.2.30",
     "@types/yauzl": "2.9.0",
@@ -49,8 +50,9 @@
     "lodash": "4.17.15",
     "osenv": "0.1.3",
     "semver": "5.5.1",
+    "shelljs": "0.7.6",
     "temp": "0.8.3",
     "winreg": "1.2.2",
     "yauzl": "2.10.0"
   }
-}
+}