try fixing npm_napi_release workflow

shirakaba · shirakaba · commit 31d3fcfd3c8f · 2026-02-25T13:08:13.000+09:00
diff --git a/.github/workflows/npm_napi_release.yml b/.github/workflows/npm_napi_release.yml
@@ -7,16 +7,17 @@ on:
       - "v*"
 
 env:
-  NPM_TAG: "next"
   XCODE_VERSION: "^15.0"
 
 jobs:
   build:
     name: Build
     runs-on: macos-14
     outputs:
-      npm_version: ${{ steps.npm_version_output.outputs.NPM_VERSION }}
-      npm_tag: ${{ steps.npm_version_output.outputs.NPM_TAG }}
+      npm_version_ios: ${{ steps.npm_version_output.outputs.NPM_VERSION_IOS }}
+      npm_tag_ios: ${{ steps.npm_version_output.outputs.NPM_TAG_IOS }}
+      npm_version_macos: ${{ steps.npm_version_output.outputs.NPM_VERSION_MACOS }}
+      npm_tag_macos: ${{ steps.npm_version_output.outputs.NPM_TAG_MACOS }}
     steps:
       - name: Harden the runner (Audit all outbound calls)
         uses: step-security/harden-runner@95d9a5deda9de15063e7595e9719c11c38c90ae2 # v2.13.2
@@ -57,30 +58,43 @@ jobs:
         run: |
           NPM_VERSION=$(node -e "console.log(require('./package.json').version);")
           echo NPM_VERSION=$NPM_VERSION >> $GITHUB_ENV
-      - name: Bump version for dev release
+      - name: Bump versions for dev release
         if: ${{ !contains(github.ref, 'refs/tags/') }}
         run: |
-          NPM_VERSION=$(node ./scripts/get-next-version.js)
-          echo NPM_VERSION=$NPM_VERSION >> $GITHUB_ENV
-          npm version $NPM_VERSION --no-git-tag-version
-      - name: Output NPM Version and tag
+          # Bump @nativescript/ios-node-api
+          NPM_VERSION_IOS=$(node ./scripts/get-next-version.js ios)
+          echo NPM_VERSION_IOS=$NPM_VERSION_IOS >> $GITHUB_ENV
+          cd packages/ios
+          npm version $NPM_VERSION_IOS --no-git-tag-version
+          cd -
+
+          # Bump @nativescript/macos-node-api
+          NPM_VERSION_MACOS=$(node ./scripts/get-next-version.js macos)
+          echo NPM_VERSION_MACOS=$NPM_VERSION_MACOS >> $GITHUB_ENV
+          cd packages/macos
+          npm version $NPM_VERSION_MACOS --no-git-tag-version
+          cd -
+      - name: Output NPM Versions and tags
         id: npm_version_output
         run: |
-          NPM_TAG=$(node ./scripts/get-npm-tag.js)
-          echo NPM_VERSION=$NPM_VERSION >> $GITHUB_OUTPUT
-          echo NPM_TAG=$NPM_TAG >> $GITHUB_OUTPUT
+          NPM_TAG_IOS=$(node ./scripts/get-npm-tag.js ios)
+          NPM_TAG_MACOS=$(node ./scripts/get-npm-tag.js macos)
+          echo NPM_VERSION_IOS=$NPM_VERSION_IOS >> $GITHUB_OUTPUT
+          echo NPM_VERSION_MACOS=$NPM_VERSION_MACOS >> $GITHUB_OUTPUT
+          echo NPM_TAG_IOS=$NPM_TAG_IOS >> $GITHUB_OUTPUT
+          echo NPM_TAG_MACOS=$NPM_TAG_MACOS >> $GITHUB_OUTPUT
       - name: Build
-        run: npm run build-ios
-      - name: Upload npm package artifact
+        run: ./build_all_react_native.sh
+      - name: Upload npm package artifact for @nativescript/ios-node-api
         uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
         with:
-          name: npm-package
-          path: dist/nativescript-ios-${{steps.npm_version_output.outputs.NPM_VERSION}}.tgz
-      - name: Upload dSYMs artifact
+          name: nativescript-ios-node-api
+          path: packages/ios/nativescript-ios-node-api-${{steps.npm_version_output.outputs.NPM_VERSION_IOS}}.tgz
+      - name: Upload npm package artifact for @nativescript/macos-node-api
         uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
         with:
-          name: NativeScript-dSYMs
-          path: dist/dSYMs
+          name: nativescript-macos-node-api
+          path: packages/macos/nativescript-macos-node-api-${{steps.npm_version_output.outputs.NPM_VERSION_MACOS}}.tgz
   test:
     name: Test
     runs-on: macos-14
@@ -96,7 +110,7 @@ jobs:
       - uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
       - uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
         with:
-          node-version: 22
+          node-version: 24
       - name: Install Python
         uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 # v6.1.0
         with:
@@ -174,25 +188,42 @@ jobs:
           path: dist
       - name: Update npm (required for OIDC trusted publishing)
         run: |
-          npm install -g npm@^11.5.1
+          npm install -g npm@^11.6.2
           npm --version
-      - name: Publish package (OIDC trusted publishing)
+      - name: Publish @nativescript/ios-node-api package (OIDC trusted publishing)
         if: ${{ vars.USE_NPM_TOKEN != 'true' }}
         run: |
-          echo "Publishing @nativescript/ios@$NPM_VERSION to NPM with tag $NPM_TAG via OIDC trusted publishing..."
+          echo "Publishing @nativescript/ios-node-api@$NPM_VERSION_IOS to NPM with tag $NPM_TAG_IOS via OIDC trusted publishing..."
           unset NODE_AUTH_TOKEN
           if [ -n "${NPM_CONFIG_USERCONFIG:-}" ]; then
             rm -f "$NPM_CONFIG_USERCONFIG"
           fi
-          npm publish ./dist/nativescript-ios-${{env.NPM_VERSION}}.tgz --tag $NPM_TAG --access public --provenance
+          npm publish packages/ios/nativescript-ios-node-api-${{env.NPM_VERSION_IOS}}.tgz --tag $NPM_TAG_IOS --access public --provenance
         env:
           NODE_AUTH_TOKEN: ""
-
-      - name: Publish package (granular token)
+      - name: Publish @nativescript/macos-node-api package (OIDC trusted publishing)
+        if: ${{ vars.USE_NPM_TOKEN != 'true' }}
+        run: |
+          echo "Publishing @nativescript/macos-node-api@$NPM_VERSION_MACOS to NPM with tag $NPM_TAG_MACOS via OIDC trusted publishing..."
+          unset NODE_AUTH_TOKEN
+          if [ -n "${NPM_CONFIG_USERCONFIG:-}" ]; then
+            rm -f "$NPM_CONFIG_USERCONFIG"
+          fi
+          npm publish packages/macos/nativescript-macos-node-api-${{env.NPM_VERSION_MACOS}}.tgz --tag $NPM_TAG_MACOS --access public --provenance
+        env:
+          NODE_AUTH_TOKEN: ""
+      - name: Publish @nativescript/ios-node-api package (granular token)
+        if: ${{ vars.USE_NPM_TOKEN == 'true' }}
+        run: |
+          echo "Publishing @nativescript/ios-node-api@$NPM_VERSION to NPM with tag $NPM_TAG_IOS via granular token..."
+          npm publish packages/ios/nativescript-ios-node-api-${{env.NPM_VERSION_IOS}}.tgz --tag $NPM_TAG_IOS --access public --provenance
+        env:
+          NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}
+      - name: Publish @nativescript/macos-node-api package (granular token)
         if: ${{ vars.USE_NPM_TOKEN == 'true' }}
         run: |
-          echo "Publishing @nativescript/ios@$NPM_VERSION to NPM with tag $NPM_TAG via granular token..."
-          npm publish ./dist/nativescript-ios-${{env.NPM_VERSION}}.tgz --tag $NPM_TAG --access public --provenance
+          echo "Publishing @nativescript/macos-node-api@$NPM_VERSION to NPM with tag $NPM_TAG_MACOS via granular token..."
+          npm publish packages/macos/nativescript-macos-node-api-${{env.NPM_VERSION_MACOS}}.tgz --tag $NPM_TAG_MACOS --access public --provenance
         env:
           NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}
   github-release:
@@ -216,25 +247,22 @@ jobs:
           fetch-depth: 0
       - uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
         with:
-          node-version: 22
+          node-version: 24
       - name: Setup
         run: npm install
       - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6.0.0
         with:
-          name: npm-package
-          path: dist
+          name: nativescript-ios-node-api
+          path: packages/ios
       - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6.0.0
         with:
-          name: NativeScript-dSYMs
-          path: dist/dSYMs
-      - name: Zip dSYMs
-        working-directory: dist/dSYMs
-        run: find . -maxdepth 1 -name '*.dSYM' -print | xargs -I@ zip -r @.zip @
+          name: nativescript-macos-node-api
+          path: packages/macos
       - name: Partial Changelog
         run: npx conventional-changelog -p angular -r2 > body.md
       - uses: ncipollo/release-action@b7eabc95ff50cbeeedec83973935c8f306dfcd0b # v1.20.0
         with:
-          artifacts: "dist/nativescript-ios-*.tgz,dist/dSYMs/*.zip"
+          artifacts: "packages/macos/nativescript-macos-node-api-*.tgz,packages/ios/nativescript-ios-node-api-*.tgz"
           bodyFile: "body.md"
           prerelease: ${{needs.build.outputs.npm_tag != 'latest'}}
           allowUpdates: true
diff --git a/.github/workflows/npm_release.yml b/.github/workflows/npm_release.yml
@@ -60,13 +60,13 @@ jobs:
       - name: Bump version for dev release
         if: ${{ !contains(github.ref, 'refs/tags/') }}
         run: |
-          NPM_VERSION=$(node ./scripts/get-next-version.js)
+          NPM_VERSION=$(node ./scripts/get-next-version.js root)
           echo NPM_VERSION=$NPM_VERSION >> $GITHUB_ENV
           npm version $NPM_VERSION --no-git-tag-version
       - name: Output NPM Version and tag
         id: npm_version_output
         run: |
-          NPM_TAG=$(node ./scripts/get-npm-tag.js)
+          NPM_TAG=$(node ./scripts/get-npm-tag.js root)
           echo NPM_VERSION=$NPM_VERSION >> $GITHUB_OUTPUT
           echo NPM_TAG=$NPM_TAG >> $GITHUB_OUTPUT
       - name: Build
diff --git a/prepare-target.js b/prepare-target.js
@@ -1,13 +1,16 @@
-const path = require('path');
-const fs = require('fs');
+const process = require("node:process");
+const path = require("node:path");
+const fs = require("node:fs");
 
 const cmdArgs = process.argv.slice(2);
 const target = cmdArgs[0]; // ios, macos or visionos
 
-const packagePath = path.join('package.json');
+const packagePath = path.resolve(__dirname, "package.json");
 const packageJson = JSON.parse(fs.readFileSync(packagePath));
 
 packageJson.name = `@nativescript/${target}`;
-packageJson.description = `NativeScript Runtime for ${target === 'ios' ? 'iOS' : target === 'macos' ? 'macOS' : 'visionOS'}`;
+packageJson.description = `NativeScript Runtime for ${
+  target === "ios" ? "iOS" : target === "macos" ? "macOS" : "visionOS"
+}`;
 
-fs.writeFileSync(packagePath, JSON.stringify(packageJson, null, 2));
+fs.writeFileSync(packagePath, JSON.stringify(packageJson, null, 2));
diff --git a/scripts/get-next-version.js b/scripts/get-next-version.js
@@ -1,10 +1,31 @@
+const child_process = require("node:child_process");
+const process = require("node:process");
+const fs = require("node:fs");
 const semver = require("semver");
-const child_process = require("child_process");
 const dayjs = require("dayjs");
-const fs = require("fs");
 
-const currentVersion =
-  process.env.NPM_VERSION || require("../package.json").version;
+/** @type {string} */
+let currentVersion = process.env.NPM_VERSION;
+if (!currentVersion) {
+  const cmdArgs = process.argv.slice(2);
+  const target = cmdArgs[0];
+
+  switch (target) {
+    case "root":
+      currentVersion = require("../package.json").version;
+      break;
+    case "macos":
+      currentVersion = require("../packages/macos/package.json").version;
+      break;
+    case "ios":
+      currentVersion = require("../packages/ios/package.json").version;
+      break;
+    default:
+      throw new Error(
+        `Unknown target "${target}". Expected one of "root", "macos", or "ios".`,
+      );
+  }
+}
 
 if (!currentVersion) {
   throw new Error("Invalid current version");
@@ -16,16 +37,20 @@ let prPrerelease = "";
 
 if (currentTag === "pr" && process.env.GITHUB_EVENT_PATH) {
   try {
-    const ev = JSON.parse(fs.readFileSync(process.env.GITHUB_EVENT_PATH, "utf8"));
+    const ev = JSON.parse(
+      fs.readFileSync(process.env.GITHUB_EVENT_PATH, "utf8"),
+    );
     const prNum = ev.pull_request.number;
     // add extra PR number to version-pr.PRNUM-....
     prPrerelease = `${prNum}-`;
-  } catch (e) {
+  } catch {
     // don't add pr prerelease
   }
 }
 
-const preRelease = `${currentTag}.${prPrerelease}${dayjs().format("YYYY-MM-DD")}-${runID}`;
+const preRelease = `${currentTag}.${prPrerelease}${dayjs().format(
+  "YYYY-MM-DD",
+)}-${runID}`;
 
 function normalizeVersionCandidate(candidate) {
   if (!candidate) {
@@ -49,7 +74,9 @@ function normalizeVersionCandidate(candidate) {
   }
 
   // Supports tag formats such as refs/tags/v1.2.3, pkg@1.2.3, etc.
-  const extracted = trimmed.match(/\d+\.\d+\.\d+(?:-[0-9A-Za-z.-]+)?(?:\+[0-9A-Za-z.-]+)?/);
+  const extracted = trimmed.match(
+    /\d+\.\d+\.\d+(?:-[0-9A-Za-z.-]+)?(?:\+[0-9A-Za-z.-]+)?/,
+  );
   if (extracted && semver.parse(extracted[0])) {
     return extracted[0];
   }
@@ -58,7 +85,9 @@ function normalizeVersionCandidate(candidate) {
 }
 
 function getLastTagVersion() {
-  const explicitTagVersion = normalizeVersionCandidate(process.env.LAST_TAGGED_VERSION);
+  const explicitTagVersion = normalizeVersionCandidate(
+    process.env.LAST_TAGGED_VERSION,
+  );
   if (explicitTagVersion) {
     return explicitTagVersion;
   }
@@ -95,7 +124,7 @@ const lastTagVersion = getLastTagVersion();
 function setPreRelease(version) {
   const parsed = semver.parse(version);
   return semver.parse(
-    `${parsed.major}.${parsed.minor}.${parsed.patch}-${preRelease}`
+    `${parsed.major}.${parsed.minor}.${parsed.patch}-${preRelease}`,
   );
 }
 
diff --git a/scripts/get-npm-tag.js b/scripts/get-npm-tag.js
@@ -1,7 +1,27 @@
+const process = require("node:process");
 const semver = require("semver");
 
-const currentVersion =
-  process.env.NPM_VERSION || require("../package.json").version;
+let currentVersion = process.env.NPM_VERSION;
+if (!currentVersion) {
+  const cmdArgs = process.argv.slice(2);
+  const target = cmdArgs[0];
+
+  switch (target) {
+    case "root":
+      currentVersion = require("../package.json").version;
+      break;
+    case "macos":
+      currentVersion = require("../packages/macos/package.json").version;
+      break;
+    case "ios":
+      currentVersion = require("../packages/ios/package.json").version;
+      break;
+    default:
+      throw new Error(
+        `Unknown target "${target}". Expected one of "root", "macos", or "ios".`,
+      );
+  }
+}
 
 function validateNpmTag(version) {
   const parsed = semver.parse(version);
