Skip to content

Commit 45ffa73

Browse files
[None][infra] Address CodeRabbit review feedback
- Remove duplicate BB Vision/Multi-Modal section in ad-onboard-reviewer.md - Remove stale --benchmark.enabled flag from .vscode/launch.json - Update copyright year to 2025-2026 in _onnx_schemas.py Signed-off-by: Govind Ramnarayan <105831528+govind-ramnarayan@users.noreply.github.com>
1 parent 5a2fb55 commit 45ffa73

File tree

3 files changed

+1
-11
lines changed

3 files changed

+1
-11
lines changed

.claude/agents/ad-onboard-reviewer.md

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,6 @@ Read the actual source code for each check. Cite `file:line_number` for every PA
4444

4545
Note: BB1–BB2 only apply if the HF source indicates the model is multi-modal (has image/audio inputs). Mark N/A with justification for pure language models.
4646

47-
### BB. Vision / Multi-Modal Support
48-
49-
| # | Check | How to verify |
50-
|---|-------|---------------|
51-
| BB1 | If the model has a vision tower (multi-modal), the full `nn.Module` hierarchy for the vision component is present in the modeling file — it is NOT omitted, stubbed out, or replaced with a `pass` body | Grep for vision-related class names (e.g., `VisionTower`, `ViT`, `CLIPVision`, `SiglipVision`) from the HF source. If the model is multi-modal and none appear, flag as FAIL. |
52-
| BB2 | The test file asserts that vision-related weight keys are present in the model's `state_dict` after `load_state_dict` | Grep the test file for assertions on vision weight key names (or a check that vision-prefixed keys are in the loaded state_dict). Absence of any such assertion is a FAIL for multi-modal models. |
53-
54-
Note: BB1–BB2 only apply if the HF source indicates the model is multi-modal (has image/audio inputs). Mark N/A with justification for pure language models.
55-
5647
### C. Ops & Compatibility (STRICT — canonical ops are the backbone of AD)
5748

5849
| # | Check | How to verify |

examples/auto_deploy/.vscode/launch.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
"--args.attn-page-size=16",
1515
"--args.transforms.insert-cached-attention.backend=flashinfer",
1616
"--args.model-factory=AutoModelForCausalLM",
17-
"--benchmark.enabled=false",
1817
"--prompt.batch-size=2",
1918
"--args.model-kwargs.num-hidden-layers=3",
2019
"--args.model-kwargs.num-attention-heads=32",

tensorrt_llm/_torch/auto_deploy/transform/library/_onnx_schemas.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright (c) 2025, NVIDIA CORPORATION. All rights reserved.
1+
# Copyright (c) 2025-2026, NVIDIA CORPORATION. All rights reserved.
22
#
33
# Licensed under the Apache License, Version 2.0 (the "License");
44
# you may not use this file except in compliance with the License.

0 commit comments

Comments
 (0)