Merge pull request #7 from NMFS-RADFish/task/pass-name-as-arg

Update output directory path

Author: thgaskell

.eslintrc

@@ -0,0 +1,23 @@
+{
+  "env": {
+    "node": true,
+    "es2021": true
+  },
+  "extends": [
+    "eslint:recommended",
+    "prettier"
+  ],
+  "parserOptions": {
+    "ecmaVersion": 12,
+    "sourceType": "module",
+    "ecmaFeatures": {
+      "jsx": true
+    }
+  },
+  "plugins": [
+    "prettier"
+  ],
+  "rules": {
+    "prettier/prettier": "error"
+  }
+}

.github/workflows/run-tests.yml

@@ -15,10 +15,13 @@ jobs:
       - name: Use Node.js
         uses: actions/setup-node@v1
         with:
-          node-version: '18'
+          node-version: "18"
 
       - name: Install build dependencies
         run: npm install
 
+      - name: Lint code
+        run: npm run lint
+
       - name: Run tests
         run: npm test

.prettierrc

@@ -0,0 +1,8 @@
+{
+  "semi": true,
+  "tabWidth": 2,
+  "printWidth": 100,
+  "singleQuote": false,
+  "trailingComma": "all",
+  "bracketSpacing": true
+}

config.js

@@ -61,8 +61,7 @@ const applicationTypes = [
   {
     name: "None of the above",
     value: "other",
-    description:
-      "By selecting this option, you are skipping any preconfigured application setup",
+    description: "By selecting this option, you are skipping any preconfigured application setup",
   },
 ];
 

index.js

@@ -1,55 +1,46 @@
 #!/usr/bin/env node
 import { execSync } from "child_process";
-import { fileURLToPath } from "url";
-import { join, dirname } from "path";
 import { confirm } from "@inquirer/prompts";
 import select from "@inquirer/select";
 import { Command } from "commander";
 import ora from "ora";
 import { validateRegion } from "./validators.js";
 import { regionConfig } from "./config.js";
+import path from "path";
 
 const program = new Command();
 
-// checking to see if vals are provided as argv
-// if not, proceed with inquirer
-let regionProvidedAsArgv = false;
-
 program
   .name("Create Radfish App")
   .description("The CLI to bootstrap a radfish app!")
   .version("0.0.1");
 
 // program options
-program
-  .argument("<repository>")
-  .option("-r --region <string>", "specified region");
+program.argument("<projectDirectoryPath>").option("-r --region <string>", "specified region");
 
-program.action((repository, options) => {
+program.action((projectDirectoryPath, options) => {
   const isValidRegion = validateRegion(options.region);
 
   if (!isValidRegion) {
     const regionCodes = regionConfig
       .map((region) => region.code)
       .join(" , ")
       .replace(/, $/, ""); // remove comma from last elem
-    console.error(
-      "Invalid region code. Here are the valid regions: ",
-      regionCodes
-    );
+    console.error("Invalid region code. Here are the valid regions: ", regionCodes);
   }
 
-  scaffoldRadFishApp(repository);
+  scaffoldRadFishApp(projectDirectoryPath);
 });
 
 // check options passed in via cli command
 const options = program.opts();
 
-if (options && options.region) {
-  regionProvidedAsArgv = true;
-}
+async function scaffoldRadFishApp(projectDirectoryPath) {
+  const targetDirectory = path.resolve(
+    process.cwd(),
+    `${projectDirectoryPath.trim().replace(/\s+/g, "-")}`, // replace whitespaces in the filepath
+  );
 
-async function scaffoldRadFishApp(repository) {
   async function defineRegion() {
     return await select({
       name: "region",
@@ -60,19 +51,14 @@ async function scaffoldRadFishApp(repository) {
 
   async function confirmConfiguration(region) {
     return await confirm({
-      message: `You are about to scaffold an application for the region of ${region} in the following project directory: ../${repository}
+      message: `You are about to scaffold an application for the region of ${region} in the following project directory: ${targetDirectory}
       Okay to proceed?`,
     });
   }
 
   // this will clone the radfish app boilerplate and spin it up
   function bootstrapApp() {
     const repoUrl = "git@github.com:NMFS-RADFish/boilerplate.git"; // via ssh each user/developer will need to have ssh keypair setup in github org
-    const targetDirectory = `../${repository.replace(/\s+/g, "-")}`; // remove any whitespaces from filepath...just in case
-
-    const __filename = fileURLToPath(import.meta.url);
-    const __dirname = dirname(__filename);
-
     const spinner = ora("Setting up application").start();
 
     // Clone the repository
@@ -85,8 +71,7 @@ async function scaffoldRadFishApp(repository) {
     }
 
     // Change to the cloned repository directory
-    const repoPath = join(__dirname, targetDirectory);
-    process.chdir(repoPath);
+    process.chdir(targetDirectory);
 
     // Run an npm script (replace 'your-script-name' with the actual npm script name)
     try {