diff --git a/infrastructure/modules/inspector/context.tf b/infrastructure/modules/inspector/context.tf new file mode 100644 index 0000000..5eb0bc6 --- /dev/null +++ b/infrastructure/modules/inspector/context.tf @@ -0,0 +1,365 @@ +# +# ONLY EDIT THIS FILE IN github.com/NHSDigital/screening-terraform-modules-aws/infrastructure/modules/tags +# All other instances of this file should be a copy of that one +# +# +# Copy this file from https://github.com/NHSDigital/screening-terraform-modules-aws/blob/master/infrastructure/modules/tags/exports/context.tf +# and then place it in your Terraform module to automatically get +# tag module standard configuration inputs suitable for passing +# to other modules. +# +# curl -sL https://raw.githubusercontent.com/NHSDigital/screening-terraform-modules-aws/master/infrastructure/modules/tags/exports/context.tf -o context.tf +# +# Modules should access the whole context as `module.this.context` +# to get the input variables with nulls for defaults, +# for example `context = module.this.context`, +# and access individual variables as `module.this.`, +# with final values filled in. +# +# For example, when using defaults, `module.this.context.delimiter` +# will be null, and `module.this.delimiter` will be `-` (hyphen). +# + +module "this" { + source = "git::https://github.com/NHSDigital/screening-terraform-modules-aws.git//infrastructure/modules/tags?ref=feature/BCSS-23189-add-new-modules-to-suppport-bcss" + + service = var.service + project = var.project + region = var.region + environment = var.environment + stack = var.stack + workspace = var.workspace + name = var.name + delimiter = var.delimiter + attributes = var.attributes + tags = var.tags + additional_tag_map = var.additional_tag_map + label_order = var.label_order + regex_replace_chars = var.regex_replace_chars + id_length_limit = var.id_length_limit + label_key_case = var.label_key_case + label_value_case = var.label_value_case + descriptor_formats = var.descriptor_formats + labels_as_tags = var.labels_as_tags + + context = var.context +} + +# Copy contents of screening-terraform-modules-aws/tags/variables.tf here +# tflint-ignore: terraform_unused_declarations +variable "aws_region" { + type = string + description = "The AWS region" + default = "eu-west-2" + validation { + condition = contains(["eu-west-1", "eu-west-2", "us-east-1"], var.aws_region) + error_message = "AWS Region must be one of eu-west-1, eu-west-2, us-east-1" + } +} + +variable "context" { + type = any + default = { + enabled = true + service = null + project = null + region = null + environment = null + stack = null + workspace = null + delimiter = null + attributes = [] + tags = {} + additional_tag_map = {} + regex_replace_chars = null + label_order = [] + id_length_limit = null + label_key_case = null + label_value_case = null + descriptor_formats = {} + # Note: we have to use [] instead of null for unset lists due to + # https://github.com/hashicorp/terraform/issues/28137 + # which was not fixed until Terraform 1.0.0, + # but we want the default to be all the labels in `label_order` + # and we want users to be able to prevent all tag generation + # by setting `labels_as_tags` to `[]`, so we need + # a different sentinel to indicate "default" + labels_as_tags = ["unset"] + } + description = <<-EOT + Single object for setting entire context at once. + See description of individual variables for details. + Leave string and numeric variables as `null` to use default value. + Individual variable settings (non-null) override settings in context object, + except for attributes, tags, and additional_tag_map, which are merged. + EOT + + validation { + condition = lookup(var.context, "label_key_case", null) == null ? true : contains(["lower", "title", "upper"], var.context["label_key_case"]) + error_message = "Allowed values: `lower`, `title`, `upper`." + } + + validation { + condition = lookup(var.context, "label_value_case", null) == null ? true : contains(["lower", "title", "upper", "none"], var.context["label_value_case"]) + error_message = "Allowed values: `lower`, `title`, `upper`, `none`." + } +} + +variable "enabled" { + type = bool + default = null + description = "Set to false to prevent the module from creating any resources" +} + +variable "service" { + type = string + default = null + description = "ID element. Usually an abbreviation of your service directorate name, e.g. 'bcss' or 'csms', to help ensure generated IDs are globally unique" +} + +variable "region" { + type = string + default = null + description = "ID element _(Rarely used, not included by default)_. Usually an abbreviation of the selected AWS region e.g. 'uw2', 'ew2' or 'gbl' for resources like IAM roles that have no region" +} + +variable "project" { + type = string + default = null + description = "ID element. A project identifier, indicating the name or role of the project the resource is for, such as `website` or `api`" +} +variable "stack" { + type = string + default = null + description = "ID element. The name of the stack/component, e.g. `database`, `web`, `waf`, `eks`" +} +variable "workspace" { + type = string + default = null + description = "ID element. The Terraform workspace, to help ensure generated IDs are unique across workspaces" +} +variable "environment" { + type = string + default = null + description = "ID element. Usually used to indicate role, e.g. 'prd', 'dev', 'test', 'preprod', 'prod', 'uat'" +} + +variable "name" { + type = string + default = null + description = <<-EOT + ID element. Usually the component or solution name, e.g. 'app' or 'jenkins'. + This is the only ID element not also included as a `tag`. + The "name" tag is set to the full `id` string. There is no tag with the value of the `name` input. + EOT +} + +variable "delimiter" { + type = string + default = null + description = <<-EOT + Delimiter to be used between ID elements. + Defaults to `-` (hyphen). Set to `""` to use no delimiter at all. + EOT +} + +variable "attributes" { + type = list(string) + default = [] + description = <<-EOT + ID element. Additional attributes (e.g. `workers` or `cluster`) to add to `id`, + in the order they appear in the list. New attributes are appended to the + end of the list. The elements of the list are joined by the `delimiter` + and treated as a single ID element. + EOT +} + +variable "labels_as_tags" { + type = set(string) + default = ["default"] + description = <<-EOT + Set of labels (ID elements) to include as tags in the `tags` output. + Default is to include all labels. + Tags with empty values will not be included in the `tags` output. + Set to `[]` to suppress all generated tags. + **Notes:** + The value of the `name` tag, if included, will be the `id`, not the `name`. + Unlike other `null-label` inputs, the initial setting of `labels_as_tags` cannot be + changed in later chained modules. Attempts to change it will be silently ignored. + EOT +} + +variable "tags" { + type = map(string) + default = {} + description = <<-EOT + Additional tags (e.g. `{'BusinessUnit': 'XYZ'}`). + Neither the tag keys nor the tag values will be modified by this module. + EOT +} + +variable "additional_tag_map" { + type = map(string) + default = {} + description = <<-EOT + Additional key-value pairs to add to each map in `tags_as_list_of_maps`. Not added to `tags` or `id`. + This is for some rare cases where resources want additional configuration of tags + and therefore take a list of maps with tag key, value, and additional configuration. + EOT +} + +variable "label_order" { + type = list(string) + default = null + description = <<-EOT + The order in which the labels (ID elements) appear in the `id`. + Defaults to ["namespace", "environment", "stage", "name", "attributes"]. + You can omit any of the 6 labels ("tenant" is the 6th), but at least one must be present. + EOT +} + +variable "regex_replace_chars" { + type = string + default = null + description = <<-EOT + Terraform regular expression (regex) string. + Characters matching the regex will be removed from the ID elements. + If not set, `"/[^a-zA-Z0-9-]/"` is used to remove all characters other than hyphens, letters and digits. + EOT +} + +variable "id_length_limit" { + type = number + default = null + description = <<-EOT + Limit `id` to this many characters (minimum 6). + Set to `0` for unlimited length. + Set to `null` for keep the existing setting, which defaults to `0`. + Does not affect `id_full`. + EOT + validation { + condition = var.id_length_limit == null ? true : var.id_length_limit >= 6 || var.id_length_limit == 0 + error_message = "The id_length_limit must be >= 6 if supplied (not null), or 0 for unlimited length." + } +} + +variable "label_key_case" { + type = string + default = null + description = <<-EOT + Controls the letter case of the `tags` keys (label names) for tags generated by this module. + Does not affect keys of tags passed in via the `tags` input. + Possible values: `lower`, `title`, `upper`. + Default value: `title`. + EOT + + validation { + condition = var.label_key_case == null ? true : contains(["lower", "title", "upper"], var.label_key_case) + error_message = "Allowed values: `lower`, `title`, `upper`." + } +} + +variable "label_value_case" { + type = string + default = null + description = <<-EOT + Controls the letter case of ID elements (labels) as included in `id`, + set as tag values, and output by this module individually. + Does not affect values of tags passed in via the `tags` input. + Possible values: `lower`, `title`, `upper` and `none` (no transformation). + Set this to `title` and set `delimiter` to `""` to yield Pascal Case IDs. + Default value: `lower`. + EOT + + validation { + condition = var.label_value_case == null ? true : contains(["lower", "title", "upper", "none"], var.label_value_case) + error_message = "Allowed values: `lower`, `title`, `upper`, `none`." + } +} + +variable "descriptor_formats" { + type = any + default = {} + description = <<-EOT + Describe additional descriptors to be output in the `descriptors` output map. + Map of maps. Keys are names of descriptors. Values are maps of the form + `{ + format = string + labels = list(string) + }` + (Type is `any` so the map values can later be enhanced to provide additional options.) + `format` is a Terraform format string to be passed to the `format()` function. + `labels` is a list of labels, in order, to pass to `format()` function. + Label values will be normalized before being passed to `format()` so they will be + identical to how they appear in `id`. + Default is `{}` (`descriptors` output will be empty). + EOT +} + +variable "owner" { + type = string + description = "The name and or NHS.net email address of the service owner" + default = "None" +} + +variable "tag_version" { + type = string + description = "Used to identify the tagging version in use" + default = "1.0" +} + +variable "data_classification" { + type = string + description = "Used to identify the data classification of the resource, e.g 1-5" + default = "n/a" + validation { + condition = contains(["n/a", "1", "2", "3", "4", "5"], var.data_classification) + error_message = "Data Classification must be \"n/a\" or between 1-5" + } +} + +variable "data_type" { + type = string + description = "The tag data_type" + default = "None" + validation { + condition = contains(["None", "PCD", "PID", "Anonymised", "UserAccount", "Audit"], var.data_type) + error_message = "Data Type must be one of None, PCD, PID, Anonymised, UserAccount, Audit" + } +} + + +variable "public_facing" { + type = bool + description = "Whether this resource is public facing" + default = false +} + +variable "service_category" { + type = string + description = "The tag service_category" + default = "n/a" + validation { + condition = contains(["n/a", "Bronze", "Silver", "Gold", "Platinum"], var.service_category) + error_message = "The Service Category must be one of n/a, Bronze, Silver, Gold, Platinum" + } +} +variable "on_off_pattern" { + type = string + description = "Used to turn resources on and off based on a time pattern" + default = "n/a" +} + +variable "application_role" { + type = string + description = "The role the application is performing" + default = "General" +} + +variable "tool" { + type = string + description = "The tool used to deploy the resource" + default = "Terraform" +} + +#### End of copy of screening-terraform-modules-aws/tags/variables.tf diff --git a/infrastructure/modules/inspector/main.tf b/infrastructure/modules/inspector/main.tf new file mode 100644 index 0000000..e3164b1 --- /dev/null +++ b/infrastructure/modules/inspector/main.tf @@ -0,0 +1,28 @@ +################################################################ +# Inspector +# +# Thin wrapper around the upstream `cloudposse/inspector/aws` +# module, pinned to a specific version. Naming and tagging are +# derived from `context.tf` via `module.this` and passed through +# to the upstream module so resources composed by sibling +# screening modules stay consistent. +# +# Reference: +# https://registry.terraform.io/modules/cloudposse/inspector/aws/latest +################################################################ + +module "inspector" { + source = "cloudposse/inspector/aws" + version = "0.4.0" + + enabled_rules = var.enabled_rules + + assessment_duration = var.assessment_duration + schedule_expression = var.schedule_expression + event_rule_description = var.event_rule_description + create_iam_role = var.create_iam_role + iam_role_arn = var.iam_role_arn + assessment_event_subscription = var.assessment_event_subscription + + context = module.this.context +} diff --git a/infrastructure/modules/inspector/outputs.tf b/infrastructure/modules/inspector/outputs.tf new file mode 100644 index 0000000..626d5c3 --- /dev/null +++ b/infrastructure/modules/inspector/outputs.tf @@ -0,0 +1,19 @@ +output "inspector_assessment_target" { + description = "The AWS Inspector assessment target." + value = module.inspector.inspector_assessment_target +} + +output "aws_inspector_assessment_template" { + description = "The AWS Inspector assessment template." + value = module.inspector.aws_inspector_assessment_template +} + +output "aws_cloudwatch_event_rule" { + description = "The CloudWatch event rule that triggers the Inspector assessment." + value = module.inspector.aws_cloudwatch_event_rule +} + +output "aws_cloudwatch_event_target" { + description = "The CloudWatch event target wiring the schedule to the Inspector assessment." + value = module.inspector.aws_cloudwatch_event_target +} diff --git a/infrastructure/modules/inspector/readme.md b/infrastructure/modules/inspector/readme.md new file mode 100644 index 0000000..8e36de8 --- /dev/null +++ b/infrastructure/modules/inspector/readme.md @@ -0,0 +1,81 @@ +# Inspector + +Thin wrapper around [`cloudposse/inspector/aws`](https://registry.terraform.io/modules/cloudposse/inspector/aws/latest) +(pinned to `0.4.0`) so screening services can enable AWS Inspector +Classic with consistent naming and tagging via the shared +`context.tf`. + +For Inspector v2 (continuous scanning of EC2, ECR and Lambda), +build a separate module using the `aws_inspector2_*` resources. + + + +## Requirements + +No requirements. + +## Modules + +| Name | Source | Version | +|------|--------|---------| +| [inspector](#module_inspector) | `cloudposse/inspector/aws` | 0.4.0 | +| [this](#module_this) | `git::https://github.com/NHSDigital/screening-terraform-modules-aws.git//infrastructure/modules/tags` | feature/BCSS-23189-add-new-modules-to-suppport-bcss | + +## Resources + +Resources are created by the upstream `cloudposse/inspector/aws` module. See its +documentation for the full list (assessment target, assessment template, +CloudWatch event rule, CloudWatch event target, and optional IAM role). + +## Inputs + +| Name | Description | Type | Default | Required | +|------|-------------|------|---------|:--------:| +| [additional_tag_map](#input_additional_tag_map) | Additional key-value pairs to add to each map in `tags_as_list_of_maps`. Not added to `tags` or `id`. | `map(string)` | `{}` | no | +| [application_role](#input_application_role) | The role the application is performing | `string` | `"General"` | no | +| [assessment_duration](#input_assessment_duration) | Maximum duration of the Inspector assessment run, in seconds. | `string` | `"3600"` | no | +| [assessment_event_subscription](#input_assessment_event_subscription) | Map of assessment template event subscriptions. Each entry sends notifications about a specified assessment template event to a designated SNS topic. |
map(object({
event = string
topic_arn = string
}))
| `{}` | no | +| [attributes](#input_attributes) | ID element. Additional attributes (e.g. `workers` or `cluster`) to add to `id`, in the order they appear in the list. | `list(string)` | `[]` | no | +| [aws_region](#input_aws_region) | The AWS region | `string` | `"eu-west-2"` | no | +| [context](#input_context) | Single object for setting entire context at once. See description of individual variables for details. | `any` | see `context.tf` | no | +| [create_iam_role](#input_create_iam_role) | Whether to create the IAM role used by the CloudWatch event rule to start the Inspector assessment. | `bool` | `false` | no | +| [data_classification](#input_data_classification) | Used to identify the data classification of the resource, e.g 1-5 | `string` | `"n/a"` | no | +| [data_type](#input_data_type) | The tag data_type | `string` | `"None"` | no | +| [delimiter](#input_delimiter) | Delimiter to be used between ID elements. Defaults to `-` (hyphen). | `string` | `null` | no | +| [descriptor_formats](#input_descriptor_formats) | Describe additional descriptors to be output in the `descriptors` output map. | `any` | `{}` | no | +| [enabled](#input_enabled) | Set to false to prevent the module from creating any resources | `bool` | `null` | no | +| [enabled_rules](#input_enabled_rules) | A list of AWS Inspector Classic rule packages to run on a periodic basis. Valid: cve, cis, nr, sbp. | `list(string)` | n/a | yes | +| [environment](#input_environment) | ID element. Usually used to indicate role, e.g. 'prd', 'dev', 'test', 'preprod', 'prod', 'uat' | `string` | `null` | no | +| [event_rule_description](#input_event_rule_description) | Description of the CloudWatch event rule that triggers the Inspector assessment. | `string` | `"Trigger an AWS Inspector Assessment"` | no | +| [iam_role_arn](#input_iam_role_arn) | ARN of an existing IAM role used to start the Inspector assessment. Only used when `create_iam_role` is false. | `string` | `null` | no | +| [id_length_limit](#input_id_length_limit) | Limit `id` to this many characters (minimum 6). | `number` | `null` | no | +| [label_key_case](#input_label_key_case) | Controls the letter case of the `tags` keys (label names) for tags generated by this module. | `string` | `null` | no | +| [label_order](#input_label_order) | The order in which the labels (ID elements) appear in the `id`. | `list(string)` | `null` | no | +| [label_value_case](#input_label_value_case) | Controls the letter case of ID elements (labels) as included in `id`, set as tag values, and output by this module individually. | `string` | `null` | no | +| [labels_as_tags](#input_labels_as_tags) | Set of labels (ID elements) to include as tags in the `tags` output. | `set(string)` | `["default"]` | no | +| [name](#input_name) | ID element. Usually the component or solution name, e.g. 'app' or 'jenkins'. | `string` | `null` | no | +| [on_off_pattern](#input_on_off_pattern) | Used to turn resources on and off based on a time pattern | `string` | `"n/a"` | no | +| [owner](#input_owner) | The name and or NHS.net email address of the service owner | `string` | `"None"` | no | +| [project](#input_project) | ID element. A project identifier, indicating the name or role of the project the resource is for. | `string` | `null` | no | +| [public_facing](#input_public_facing) | Whether this resource is public facing | `bool` | `false` | no | +| [regex_replace_chars](#input_regex_replace_chars) | Terraform regular expression (regex) string. Characters matching the regex will be removed from the ID elements. | `string` | `null` | no | +| [region](#input_region) | ID element. Short region abbreviation e.g. 'uw2', 'ew2'. | `string` | `null` | no | +| [schedule_expression](#input_schedule_expression) | AWS CloudWatch schedule expression controlling how often assessments run. | `string` | `"rate(7 days)"` | no | +| [service](#input_service) | ID element. Service directorate abbreviation, e.g. 'bcss'. | `string` | `null` | no | +| [service_category](#input_service_category) | The tag service_category | `string` | `"n/a"` | no | +| [stack](#input_stack) | ID element. The name of the stack/component, e.g. `database`, `web`, `waf`, `eks`. | `string` | `null` | no | +| [tag_version](#input_tag_version) | Used to identify the tagging version in use | `string` | `"1.0"` | no | +| [tags](#input_tags) | Additional tags (e.g. `{'BusinessUnit': 'XYZ'}`). | `map(string)` | `{}` | no | +| [tool](#input_tool) | The tool used to deploy the resource | `string` | `"Terraform"` | no | +| [workspace](#input_workspace) | ID element. The Terraform workspace, to help ensure generated IDs are unique across workspaces. | `string` | `null` | no | + +## Outputs + +| Name | Description | +|------|-------------| +| [aws_cloudwatch_event_rule](#output_aws_cloudwatch_event_rule) | The CloudWatch event rule that triggers the Inspector assessment. | +| [aws_cloudwatch_event_target](#output_aws_cloudwatch_event_target) | The CloudWatch event target wiring the schedule to the Inspector assessment. | +| [aws_inspector_assessment_template](#output_aws_inspector_assessment_template) | The AWS Inspector assessment template. | +| [inspector_assessment_target](#output_inspector_assessment_target) | The AWS Inspector assessment target. | + + diff --git a/infrastructure/modules/inspector/variables.tf b/infrastructure/modules/inspector/variables.tf new file mode 100644 index 0000000..bf7656a --- /dev/null +++ b/infrastructure/modules/inspector/variables.tf @@ -0,0 +1,83 @@ +################################################################ +# Inspector-specific inputs. +# +# Naming, tagging and the master `enabled` switch come from +# `context.tf` via `module.this` and are forwarded to the +# upstream `cloudposse/inspector/aws` module as `context`. +################################################################ + +variable "enabled_rules" { + description = <<-EOT + A list of AWS Inspector Classic rule packages to run on a periodic basis. + Valid short identifiers (resolved per-region by the upstream module): + cve - Common Vulnerabilities & Exposures + cis - Center for Internet Security benchmarks + nr - Network Reachability + sbp - Security Best Practices + EOT + type = list(string) + + validation { + condition = length(var.enabled_rules) > 0 + error_message = "At least one rule package must be specified in enabled_rules." + } + + validation { + condition = alltrue([ + for r in var.enabled_rules : contains(["cve", "cis", "nr", "sbp"], r) + ]) + error_message = "enabled_rules entries must be one of: cve, cis, nr, sbp." + } +} + +variable "assessment_duration" { + description = "Maximum duration of the Inspector assessment run, in seconds." + type = string + default = "3600" +} + +variable "schedule_expression" { + description = "AWS CloudWatch schedule expression controlling how often assessments run. See https://docs.aws.amazon.com/AmazonCloudWatch/latest/events/ScheduledEvents.html" + type = string + default = "rate(7 days)" +} + +variable "event_rule_description" { + description = "Description of the CloudWatch event rule that triggers the Inspector assessment." + type = string + default = "Trigger an AWS Inspector Assessment" +} + +################################################################ +# IAM role +################################################################ + +variable "create_iam_role" { + description = "Whether to create the IAM role used by the CloudWatch event rule to start the Inspector assessment. Set to false to supply an existing role via `iam_role_arn`." + type = bool + default = false +} + +variable "iam_role_arn" { + description = "ARN of an existing IAM role used to start the Inspector assessment. Only used when `create_iam_role` is false." + type = string + default = null +} + +################################################################ +# Notifications +################################################################ + +variable "assessment_event_subscription" { + description = <<-EOT + Map of assessment template event subscriptions. Each entry sends + notifications about a specified assessment template event to a designated + SNS topic. Keys are caller-supplied identifiers used as the map key for + `for_each`-style stability. + EOT + type = map(object({ + event = string + topic_arn = string + })) + default = {} +}