Rename deploy_mock_webhook var

Author: mjewildnhs

infrastructure/terraform/components/callbacks/README.md

@@ -18,7 +18,7 @@
 | <a name="input_client_config_bucket_force_destroy"></a> [client\_config\_bucket\_force\_destroy](#input\_client\_config\_bucket\_force\_destroy) | Force-delete all objects and versions from the client config bucket during destroy | `bool` | `false` | no |
 | <a name="input_component"></a> [component](#input\_component) | The variable encapsulating the name of this component | `string` | `"callbacks"` | no |
 | <a name="input_default_tags"></a> [default\_tags](#input\_default\_tags) | A map of default tags to apply to all taggable resources within the component | `map(string)` | `{}` | no |
-| <a name="input_deploy_mock_webhook"></a> [deploy\_mock\_webhook](#input\_deploy\_mock\_webhook) | Flag to deploy mock webhook lambda for integration testing (test/dev environments only) | `bool` | `false` | no |
+| <a name="input_deploy_mock_client_subscriptions"></a> [deploy\_mock\_client\_subscriptions](#input\_deploy\_mock\_client\_subscriptions) | Flag to deploy mock webhook lambda for integration testing (test/dev environments only) | `bool` | `false` | no |
 | <a name="input_enable_event_anomaly_detection"></a> [enable\_event\_anomaly\_detection](#input\_enable\_event\_anomaly\_detection) | Enable CloudWatch anomaly detection alarm for inbound event queue message reception | `bool` | `true` | no |
 | <a name="input_environment"></a> [environment](#input\_environment) | The name of the tfscaffold environment | `string` | n/a | yes |
 | <a name="input_event_anomaly_band_width"></a> [event\_anomaly\_band\_width](#input\_event\_anomaly\_band\_width) | The width of the anomaly detection band. Higher values (e.g. 4-6) reduce sensitivity and noise, lower values (e.g. 2-3) increase sensitivity. Recommended: 2-4. | `number` | `3` | no |

infrastructure/terraform/components/callbacks/locals.tf

@@ -10,7 +10,7 @@ locals {
   mock_client_path = "${path.module}/../../../../tests/integration/fixtures/${local.mock_client_file}"
 
   discovered_config_files = fileset(local.clients_dir_path, "*.json")
-  config_files = var.deploy_mock_webhook ? setunion(
+  config_files = var.deploy_mock_client_subscriptions ? setunion(
     local.discovered_config_files,
     toset([local.mock_client_file])
   ) : local.discovered_config_files
@@ -27,10 +27,10 @@ locals {
     }
   ]...)
 
-  mock_client_id = var.deploy_mock_webhook ? local.config_clients[local.mock_client_key].clientId : ""
+  mock_client_id = var.deploy_mock_client_subscriptions ? local.config_clients[local.mock_client_key].clientId : ""
 
   # Enriched mock client config with live Lambda URL and API key (for S3 upload)
-  mock_client_config = var.deploy_mock_webhook ? merge(
+  mock_client_config = var.deploy_mock_client_subscriptions ? merge(
     local.config_clients[local.mock_client_key],
     {
       targets = [
@@ -58,7 +58,7 @@ locals {
   ]...)
 
   # Override mock targets with live Lambda URL when deployed
-  config_targets = var.deploy_mock_webhook ? merge(
+  config_targets = var.deploy_mock_client_subscriptions ? merge(
     local.raw_targets,
     { for target_id, target in local.raw_targets :
       target_id => merge(target, {

infrastructure/terraform/components/callbacks/module_mock_webhook_lambda.tf

@@ -1,5 +1,5 @@
 module "mock_webhook_lambda" {
-  count  = var.deploy_mock_webhook ? 1 : 0
+  count  = var.deploy_mock_client_subscriptions ? 1 : 0
   source = "https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/3.0.6/terraform-lambda.zip"
 
   function_name = "mock-webhook"
@@ -42,13 +42,13 @@ module "mock_webhook_lambda" {
 }
 
 resource "random_password" "mock_webhook_api_key" {
-  count   = var.deploy_mock_webhook ? 1 : 0
+  count   = var.deploy_mock_client_subscriptions ? 1 : 0
   length  = 32
   special = false
 }
 
 data "aws_iam_policy_document" "mock_webhook_lambda" {
-  count = var.deploy_mock_webhook ? 1 : 0
+  count = var.deploy_mock_client_subscriptions ? 1 : 0
 
   statement {
     sid    = "KMSPermissions"
@@ -67,7 +67,7 @@ data "aws_iam_policy_document" "mock_webhook_lambda" {
 
 # Lambda Function URL for mock webhook (test/dev only)
 resource "aws_lambda_function_url" "mock_webhook" {
-  count              = var.deploy_mock_webhook ? 1 : 0
+  count              = var.deploy_mock_client_subscriptions ? 1 : 0
   function_name      = module.mock_webhook_lambda[0].function_name
   authorization_type = "NONE" # Public endpoint for testing
 
@@ -80,7 +80,7 @@ resource "aws_lambda_function_url" "mock_webhook" {
 }
 
 resource "aws_lambda_permission" "mock_webhook_function_url" {
-  count                  = var.deploy_mock_webhook ? 1 : 0
+  count                  = var.deploy_mock_client_subscriptions ? 1 : 0
   statement_id_prefix    = "FunctionURLAllowPublicAccess"
   action                 = "lambda:InvokeFunctionUrl"
   function_name          = module.mock_webhook_lambda[0].function_name
@@ -89,7 +89,7 @@ resource "aws_lambda_permission" "mock_webhook_function_url" {
 }
 
 resource "aws_lambda_permission" "mock_webhook_function_invoke" {
-  count               = var.deploy_mock_webhook ? 1 : 0
+  count               = var.deploy_mock_client_subscriptions ? 1 : 0
   statement_id_prefix = "FunctionURLAllowInvokeAction"
   action              = "lambda:InvokeFunction"
   function_name       = module.mock_webhook_lambda[0].function_name

infrastructure/terraform/components/callbacks/outputs.tf

@@ -20,10 +20,10 @@ output "deployment" {
 
 output "mock_webhook_lambda_log_group_name" {
   description = "CloudWatch log group name for mock webhook lambda (for integration test queries)"
-  value       = var.deploy_mock_webhook ? module.mock_webhook_lambda[0].cloudwatch_log_group_name : null
+  value       = var.deploy_mock_client_subscriptions ? module.mock_webhook_lambda[0].cloudwatch_log_group_name : null
 }
 
 output "mock_webhook_url" {
   description = "URL endpoint for mock webhook (for TEST_WEBHOOK_URL environment variable)"
-  value       = var.deploy_mock_webhook ? aws_lambda_function_url.mock_webhook[0].function_url : null
+  value       = var.deploy_mock_client_subscriptions ? aws_lambda_function_url.mock_webhook[0].function_url : null
 }

infrastructure/terraform/components/callbacks/s3_bucket_client_config.tf

@@ -1,5 +1,5 @@
 resource "aws_s3_object" "mock_client_config" {
-  count = var.deploy_mock_webhook ? 1 : 0
+  count = var.deploy_mock_client_subscriptions ? 1 : 0
 
   bucket  = module.client_config_bucket.id
   key     = "client_subscriptions/mock-it-client.json"

infrastructure/terraform/components/callbacks/ssm_parameter_applications_map.tf

@@ -3,7 +3,7 @@ resource "aws_ssm_parameter" "applications_map" {
   type   = "SecureString"
   key_id = module.kms.key_arn
 
-  value = var.deploy_mock_webhook ? jsonencode({
+  value = var.deploy_mock_client_subscriptions ? jsonencode({
     (local.mock_client_id) = "mock-application-id"
   }) : jsonencode({})
 

infrastructure/terraform/components/callbacks/variables.tf

@@ -149,7 +149,7 @@ variable "event_anomaly_band_width" {
   }
 }
 
-variable "deploy_mock_webhook" {
+variable "deploy_mock_client_subscriptions" {
   type        = bool
   description = "Flag to deploy mock webhook lambda for integration testing (test/dev environments only)"
   default     = false