From 3fc2dc35b8cf5584bbad28caf1d673fab5f35e9f Mon Sep 17 00:00:00 2001
From: Shahid Azim <shahid.azim2@nhs.net>
Date: Fri, 30 Jan 2026 16:20:15 +0000
Subject: [PATCH] fix: added default values for secret and certificate expiry
 alerts

---
 infrastructure/modules/key-vault/variables.tf | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/infrastructure/modules/key-vault/variables.tf b/infrastructure/modules/key-vault/variables.tf
index 0ce79d0e..1e0b30ba 100644
--- a/infrastructure/modules/key-vault/variables.tf
+++ b/infrastructure/modules/key-vault/variables.tf
@@ -79,6 +79,12 @@ variable "secret_near_expiry_alert" {
     )
     error_message = "secret_near_expiry_alert.window_duration must be one of: PT1M, PT5M, PT15M, PT30M, PT1H, PT6H, PT12H, P1D"
   }
+
+  default = {
+    evaluation_frequency = "P1D" # every 24 hours
+    window_duration      = "P1D" # last 24 hours
+    threshold            = 1
+  }
 }
 
 variable "secret_expired_alert" {
@@ -103,6 +109,12 @@ variable "secret_expired_alert" {
     )
     error_message = "secret_expired_alert.window_duration must be one of: PT1M, PT5M, PT15M, PT30M, PT1H, PT6H, PT12H, P1D"
   }
+
+  default = {
+    evaluation_frequency = "PT15M" # every 15 mins
+    window_duration      = "PT1H"  # last 1 hour
+    threshold            = 1
+  }
 }
 
 variable "certificate_near_expiry_alert" {
@@ -127,6 +139,12 @@ variable "certificate_near_expiry_alert" {
     )
     error_message = "certificate_near_expiry_alert.window_duration must be one of: PT1M, PT5M, PT15M, PT30M, PT1H, PT6H, PT12H, P1D"
   }
+
+  default = {
+    evaluation_frequency = "P1D" # every 24 hours
+    window_duration      = "P1D" # last 24 hours
+    threshold            = 1
+  }
 }
 
 variable "certificate_expired_alert" {
@@ -151,6 +169,12 @@ variable "certificate_expired_alert" {
     )
     error_message = "certificate_expired_alert.window_duration must be one of: PT1M, PT5M, PT15M, PT30M, PT1H, PT6H, PT12H, P1D"
   }
+
+  default = {
+    evaluation_frequency = "PT15M" # every 15 mins
+    window_duration      = "PT1H"  # last 1 hour
+    threshold            = 1
+  }
 }
 
 variable "name" {