refactor: fixes following review comments

Author: stevenhsd

src/dve/pipeline/foundry_ddb_pipeline.py

@@ -44,7 +44,7 @@ def file_transformation(
             self._audit_tables.mark_failed(submissions=[submission_info.submission_id])
             return submission_info, SubmissionStatus(processing_failed=True)
 
-    def apply_data_contract(self, submission_info: SubmissionInfo, submission_status: SubmissionStatus) -> tuple[SubmissionInfo | SubmissionStatus]:
+    def apply_data_contract(self, submission_info: SubmissionInfo, submission_status: Optional[SubmissionStatus] = None) -> tuple[SubmissionInfo | SubmissionStatus]:
         try:
             return super().apply_data_contract(submission_info, submission_status)
         except Exception as exc: # pylint: disable=W0718
@@ -58,7 +58,7 @@ def apply_data_contract(self, submission_info: SubmissionInfo, submission_status
             self._audit_tables.mark_failed(submissions=[submission_info.submission_id])
             return submission_info, SubmissionStatus(processing_failed=True)
 
-    def apply_business_rules(self, submission_info: SubmissionInfo, submission_status: SubmissionStatus):
+    def apply_business_rules(self, submission_info: SubmissionInfo, submission_status: Optional[SubmissionStatus] = None):
         try:
             return super().apply_business_rules(submission_info, submission_status)
         except Exception as exc: # pylint: disable=W0718
@@ -72,7 +72,7 @@ def apply_business_rules(self, submission_info: SubmissionInfo, submission_statu
             self._audit_tables.mark_failed(submissions=[submission_info.submission_id])
             return submission_info, SubmissionStatus(processing_failed=True)
 
-    def error_report(self, submission_info: SubmissionInfo, submission_status: SubmissionStatus):
+    def error_report(self, submission_info: SubmissionInfo, submission_status: Optional[SubmissionStatus] = None):
         try:
             return super().error_report(submission_info, submission_status)
         except Exception as exc: # pylint: disable=W0718

src/dve/reporting/utils.py

@@ -47,6 +47,10 @@ def dump_processing_errors(
     """Write out critical processing errors"""
     if not working_folder:
         raise AttributeError("processed files path not passed")
+    if not step_name:
+        raise AttributeError("step name not passed")
+    if not errors:
+        raise AttributeError("errors list not passed")
 
     error_file: URI = fh.joinuri(working_folder, "errors", f"processing_errors.json")
     processed = []