Skip to content

Commit cbd4cfa

Browse files
refactor: rename "Grouping" to "Group"
1 parent 03b65ea commit cbd4cfa

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

src/dve/reporting/excel_report.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,7 @@ def _text_length(value):
445445
def _format_headings(headings: list[str]) -> list[str]:
446446
# TODO - ideally this would be config driven to allow customisation.
447447
_renames = {
448-
"Table": "Grouping",
448+
"Table": "Group",
449449
"Data Item": "Data Item Submission Name",
450450
"Error": "Errors and Warnings",
451451
}

tests/test_error_reporting/test_excel_report.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ def test_excel_report(report_dfs):
116116
column_headings = [cell.value for cell in aggs["1"]]
117117
assert column_headings == [
118118
"Type",
119-
"Grouping",
119+
"Group",
120120
"Data Item Submission Name",
121121
"Category",
122122
"Error Code",
@@ -126,7 +126,7 @@ def test_excel_report(report_dfs):
126126
details = workbook["Error Data"]
127127
column_headings = [cell.value for cell in details["1"]]
128128
assert column_headings == [
129-
"Grouping",
129+
"Group",
130130
"Type",
131131
"Error Code",
132132
"Data Item Submission Name",

tests/test_pipeline/test_spark_pipeline.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -469,7 +469,7 @@ def test_error_report_where_report_is_expected( # pylint: disable=redefined-out
469469
OrderedDict(
470470
**{
471471
"Type": "Submission Failure",
472-
"Grouping": "planets",
472+
"Group": "planets",
473473
"Data Item Submission Name": "orbitalPeriod",
474474
"Category": "Bad value",
475475
"Error Code": "LONG_ORBIT",
@@ -479,7 +479,7 @@ def test_error_report_where_report_is_expected( # pylint: disable=redefined-out
479479
OrderedDict(
480480
**{
481481
"Type": "Submission Failure",
482-
"Grouping": "planets",
482+
"Group": "planets",
483483
"Data Item Submission Name": "gravity",
484484
"Category": "Bad value",
485485
"Error Code": "STRONG_GRAVITY",
@@ -497,7 +497,7 @@ def test_error_report_where_report_is_expected( # pylint: disable=redefined-out
497497
assert error_data_records == [
498498
OrderedDict(
499499
**{
500-
"Grouping": "planets",
500+
"Group": "planets",
501501
"Type": "Submission Failure",
502502
"Error Code": "LONG_ORBIT",
503503
"Data Item Submission Name": "orbitalPeriod",
@@ -509,7 +509,7 @@ def test_error_report_where_report_is_expected( # pylint: disable=redefined-out
509509
),
510510
OrderedDict(
511511
**{
512-
"Grouping": "planets",
512+
"Group": "planets",
513513
"Type": "Submission Failure",
514514
"Error Code": "STRONG_GRAVITY",
515515
"Data Item Submission Name": "gravity",

0 commit comments

Comments
 (0)