refactor: Removed additional templating step for business rule messages as now handled elsewhere

Also tweaked how reference_data existance being checked for as truthy evaluation False where expected to be True

Author: stevenhsd

src/dve/core_engine/backends/base/core.py

@@ -76,7 +76,7 @@ def __init__(
                 raise ValueError(f"Entity name cannot start with 'refdata_', got {entity_name!r}")
             self.entities[entity_name] = entity
 
-        self.reference_data = reference_data or {}
+        self.reference_data = reference_data if reference_data is not None else {}
         """The reference data mapping."""
 
     @staticmethod

src/dve/core_engine/message.py

@@ -12,7 +12,7 @@
 from pydantic.dataclasses import dataclass
 
 from dve.core_engine.constants import CONTRACT_ERROR_VALUE_FIELD_NAME, ROWID_COLUMN_NAME
-from dve.core_engine.templating import ENVIRONMENT, template_object
+from dve.core_engine.templating import template_object
 from dve.core_engine.type_hints import (
     EntityName,
     ErrorCategory,
@@ -270,12 +270,7 @@ def to_row(
         if isinstance(reporting_field, list):
             reporting_field = ", ".join(reporting_field)
 
-        if self.record and self.error_message:
-            error_message: Optional[str] = ENVIRONMENT.from_string(self.error_message).render(
-                **self.__dict__
-            )
-        else:
-            error_message = self.error_message
+        error_message = self.error_message
 
         return (
             self.entity,

src/dve/pipeline/pipeline.py

@@ -509,7 +509,7 @@ def apply_business_rules(self, submission_info: SubmissionInfo, failed: bool):
         )
         reference_data.entity_cache["dve_submission_info"] = sub_info_entity
 
-        entity_manager = EntityManager(entities, reference_data)
+        entity_manager = EntityManager(entities=entities, reference_data=reference_data)
 
         rule_messages = self.step_implementations.apply_rules(entity_manager, rules)  # type: ignore
         key_fields = {model: conf.reporting_fields for model, conf in model_config.items()}