Skip to content

Commit 5dfbafc

Browse files
committed
refactor: small changes to foundry pipeline and duckdb csv to fix header check
1 parent 4a3f89d commit 5dfbafc

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

src/dve/core_engine/backends/implementations/duckdb/readers/csv.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
from dve.core_engine.backends.utilities import get_polars_type_from_annotation
2121
from dve.core_engine.message import FeedbackMessage
2222
from dve.core_engine.type_hints import URI, EntityName
23-
from dve.parser.file_handling import get_content_length, open_stream
23+
from dve.parser.file_handling import get_content_length
2424

2525

2626
@duckdb_write_parquet
@@ -38,7 +38,7 @@ def __init__(
3838
connection: Optional[DuckDBPyConnection] = None,
3939
field_check: bool = False,
4040
field_check_error_code: Optional[str] = "ExpectedVsActualFieldMismatch",
41-
field_check_error_message: Optional[str] = "The submitted header does not match what is expected",
41+
field_check_error_message: Optional[str] = "The submitted header is missing fields",
4242
**_,
4343
):
4444
self.header = header
@@ -67,11 +67,11 @@ def perform_field_check(
6767
messages=[
6868
FeedbackMessage(
6969
entity=entity_name,
70+
record=None,
7071
failure_type="submission",
7172
error_location="Whole File",
7273
error_code=self.field_check_error_code,
73-
error_message=self.field_check_error_message,
74-
value=f"Missing fields: {missing}",
74+
error_message=f"{self.field_check_error_message} - missing fields: {missing}",
7575
)
7676
],
7777
)

src/dve/pipeline/foundry_ddb_pipeline.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ def error_report(
109109
self._logger.exception(exc)
110110
sub_stats = None
111111
report_uri = None
112+
submission_status.processing_failed = True
112113
dump_processing_errors(
113114
fh.joinuri(self.processed_files_path, submission_info.submission_id),
114115
"error_report",
@@ -148,7 +149,8 @@ def run_pipeline(
148149
sub_info, sub_status, sub_stats, report_uri = self.error_report(
149150
submission_info=submission_info, submission_status=sub_status
150151
)
151-
self._audit_tables.add_submission_statistics_records(sub_stats=[sub_stats])
152+
if sub_stats:
153+
self._audit_tables.add_submission_statistics_records(sub_stats=[sub_stats])
152154
except Exception as err: # pylint: disable=W0718
153155
self._logger.error(
154156
f"During processing of submission_id: {sub_id}, this exception was raised: {err}"

0 commit comments

Comments
 (0)