Refactor ROLE handling to improve variable assignment and debug output

Author: sathiya-nhs

azure/components/aws-assume-role.yml

@@ -13,20 +13,18 @@ steps:
 
   - bash: |
       set -e
-      echo "##vso[task.setvariable variable=ROLE]$role"
-    env:
-      role: ${{ parameters.role }}
-    displayName: get role name
-
-  - bash: |
-      if [ -z "$(ROLE)" ]; then
-        echo "[DEBUG] ROLE is empty"
+      if [ -z "$role" ]; then
+        echo "ROLE is empty"
+        echo "##vso[task.setvariable variable=ROLE]"
         echo "##vso[task.setvariable variable=ROLE_EXISTS]false"
       else
-        echo "[DEBUG] ROLE value: $(ROLE)"
+        echo "ROLE value: $role"
+        echo "##vso[task.setvariable variable=ROLE]$role"
         echo "##vso[task.setvariable variable=ROLE_EXISTS]true"
       fi
-    displayName: "Debug ROLE value (empty or not)"
+    env:
+      role: ${{ parameters.role }}
+    displayName: get role name
 
   - bash: |
       set -e
@@ -95,4 +93,4 @@ steps:
       AWS_ACCOUNT: ${{ parameters.aws_account }}
       PROFILE: ${{ parameters.profile }}
     displayName: assume role
-    condition: and(succeeded(), eq(variables['ROLE_EXISTS'], 'true'))
+    condition: and(succeeded(), ne(variables['ROLE'], ''))