Fix formatting inconsistencies in deploy-stage.yml and update display names for clarity

Author: sathiya-nhs

azure/common/deploy-stage.yml

@@ -22,7 +22,7 @@ parameters:
   - name: fully_qualified_service_name
   - name: service_base_path
   - name: pr_label
-    default: ''
+    default: ""
   - name: secret_file_ids
     type: object
   - name: secret_ids
@@ -123,7 +123,7 @@ stages:
                     role: "auto-ops"
                     profile: "apm_${{ parameters.aws_account }}"
                     aws_account: "${{ parameters.aws_account }}"
-                
+
                 - bash: |
                     pyversion="3.13"
                     PATCH=$(curl -fsSL https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json \
@@ -133,20 +133,13 @@ stages:
                     echo "##vso[task.setvariable variable=PY_VER]$PATCH"
                     echo "Resolved latest python version: $PATCH"
                     echo "##vso[task.setvariable variable=LD_LIBRARY_PATH;]/agent/_work/_tool/Python/${PATCH}/x64/lib/"
-                  displayName: 'Query and set python tool cache path'  
-
+                  displayName: "Query and set python tool cache path"
 
                 - task: UsePythonVersion@0
                   name: UsePy
-                  displayName: 'Use Python 3.13'
+                  displayName: "Use Python 3.13"
                   inputs:
-                    versionSpec: '$(PY_VER)'
-
-                # - bash: |
-                #     echo "Checking the python version in use to set LD_LIBRARY_PATH"
-                #     echo "Python location: $(UsePy.pythonLocation)"
-                #     echo "##vso[task.setvariable variable=LD_LIBRARY_PATH]$(UsePy.pythonLocation)/lib"
-                #   displayName: 'Set LD_LIBRARY_PATH'
+                    versionSpec: "$(PY_VER)"
 
                 - template: "../components/set-facts.yml"
                   parameters:
@@ -173,27 +166,27 @@ stages:
                     apigee_organization: ${{ parameters.apigee_organization }}
 
                 - ${{ if parameters.notify }}:
-                  - bash: |
-                      if [[ -z $(NOTIFY_COMMIT_SHA) ]]; then
-                          export NOTIFY_COMMIT_SHA=`echo "$(Build.SourceVersionMessage)" | cut -d' ' -f2`
-                          echo "##vso[task.setvariable variable=NOTIFY_COMMIT_SHA]$NOTIFY_COMMIT_SHA"
-                      else
-                          echo "##[debug]Using already provided NOTIFY_COMMIT_SHA=$(NOTIFY_COMMIT_SHA)"
-                      fi
-                    displayName: Set NOTIFY_COMMIT_SHA
+                    - bash: |
+                        if [[ -z $(NOTIFY_COMMIT_SHA) ]]; then
+                            export NOTIFY_COMMIT_SHA=`echo "$(Build.SourceVersionMessage)" | cut -d' ' -f2`
+                            echo "##vso[task.setvariable variable=NOTIFY_COMMIT_SHA]$NOTIFY_COMMIT_SHA"
+                        else
+                            echo "##[debug]Using already provided NOTIFY_COMMIT_SHA=$(NOTIFY_COMMIT_SHA)"
+                        fi
+                      displayName: Set NOTIFY_COMMIT_SHA
 
-                  - template: '../components/update-github-status.yml'
-                    parameters:
-                      state: pending
-                      description: "Deploy to ${{ parameters.environment }} started"
-                      environment: ${{ parameters.environment }}
+                    - template: "../components/update-github-status.yml"
+                      parameters:
+                        state: pending
+                        description: "Deploy to ${{ parameters.environment }} started"
+                        environment: ${{ parameters.environment }}
 
                 - ${{ each param in parameters }}:
-                  - ${{ if not(containsValue(parameters._expose_blacklist, param.key)) }}:
-                    - bash: |
-                        set -euo pipefail
-                        echo "##vso[task.setvariable variable=${{ upper(param.key) }}]${{ param.value }}"
-                      displayName: Setting ${{ upper(param.key) }}=${{ param.value }}
+                    - ${{ if not(containsValue(parameters._expose_blacklist, param.key)) }}:
+                        - bash: |
+                            set -euo pipefail
+                            echo "##vso[task.setvariable variable=${{ upper(param.key) }}]${{ param.value }}"
+                          displayName: Setting ${{ upper(param.key) }}=${{ param.value }}
 
                 - bash: |
                     set -euo pipefail
@@ -261,7 +254,7 @@ stages:
                   displayName: Check supplied names against API registry
                   continueOnError: true
 
-                - template: '../templates/deploy-service.yml'
+                - template: "../templates/deploy-service.yml"
                   parameters:
                     service_name: ${{ parameters.service_name }}
                     short_service_name: ${{ parameters.short_service_name }}
@@ -282,7 +275,7 @@ stages:
                     post_deploy: ${{ parameters.post_deploy }}
                     ping: ${{ parameters.ping }}
                     enable_monitoring: ${{ parameters.enable_monitoring }}
-                    enable_status_monitoring : ${{ parameters.enable_status_monitoring  }}
+                    enable_status_monitoring: ${{ parameters.enable_status_monitoring  }}
                     portal_api_requires_callback_url: ${{ parameters.portal_api_requires_callback_url }}
                     make_spec_visible: ${{ parameters.make_spec_visible }}
                     friendly_api_name: ${{ parameters.friendly_api_name }}
@@ -291,16 +284,16 @@ stages:
                     aws_account: ${{ parameters.aws_account }}
 
                 - ${{ if parameters.notify }}:
-                  - template: '../components/update-github-status.yml'
-                    parameters:
-                      state: success
-                      on_success: true
-                      description: "Deploy to ${{ parameters.environment }} succeeded"
-                      environment: ${{ parameters.environment }}
+                    - template: "../components/update-github-status.yml"
+                      parameters:
+                        state: success
+                        on_success: true
+                        description: "Deploy to ${{ parameters.environment }} succeeded"
+                        environment: ${{ parameters.environment }}
 
-                  - template: '../components/update-github-status.yml'
-                    parameters:
-                      state: failure
-                      on_failure: true
-                      description: "Deploy to ${{ parameters.environment }} failed"
-                      environment: ${{ parameters.environment }}
+                    - template: "../components/update-github-status.yml"
+                      parameters:
+                        state: failure
+                        on_failure: true
+                        description: "Deploy to ${{ parameters.environment }} failed"
+                        environment: ${{ parameters.environment }}