Unexpected engine equipping behavior when changing ships #715
Description
What you were trying to do
Expected behavior: Changing ships should add new ship's engine to inventory and equip it, and should keep it equipped after respawn.
What actually happened
Changing ships equips the new ship's engine which is not visible in inventory but can be noticed through movement.
Additionally, if after a respawn the old ship's engine is still present in inventory, it will equip that and show movement characteristics of previous engine.
How to reproduce
- Go into a ship's config file and change it's engine to a custom defined one
- Start a new game
- Buy aforementioned ship
- Check inventory to ensure new ship's engine is not present there
- Close inventory and move around to observe movement characteristics of new ship's engine
- Respawn
- Check to see if the engine from the old ship is still present and is equipped
- Observe movement characteristics of previous ship's engine
- Repeat if the old engine was lost after respawn for the second part of the bug
Game version
Source build (commit 52b23c4, the commit after that is not relevant since it only changes the README)
Log details
No response
Operating System
Windows
Additional Info
As a side note, I also notice that even if you equip the old ship's engine before respawning, it will still add the current ship's engine to inventory upon respawn but will not equip it. I would personally think this is unnecessary and ideally should not add the engine to inventory unless there are no engines currently in inventory. It would still be ideal however to avoid adding engines for realism and have emergency thrusters instead as mentioned in #705 .