fix(skill): clarify active skill prompts#598
Conversation
🦋 Changeset detectedLatest commit: f76f4ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 091fe3e055
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
1 participant
Related Issue
No linked issue. This PR addresses a prompt-shaping bug in slash-triggered skills.
Problem
Slash-triggered skills were injected as system reminders, which made the active skill body look like host-level reminder context rather than the user's current request. This could cause the model to treat a user-invoked skill as if no user task had been provided.
What changed
kimi-skill-loadedas the skill wrapper with trigger, source, and args metadata.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.Test Plan
pnpm oxlint packages/agent-core/src/agent/skill/index.ts packages/agent-core/src/agent/skill/prompt.ts packages/agent-core/src/tools/builtin/collaboration/skill-tool.ts packages/agent-core/test/harness/skill-session.test.ts packages/agent-core/test/tools/skill-tool.test.ts packages/agent-core/test/tools/skill-tool-dispatch.test.ts packages/agent-core/test/agent/skill-tool-manager.test.ts packages/node-sdk/test/session-skills.test.tspnpm vitest run packages/agent-core/test/harness/skill-session.test.ts packages/node-sdk/test/session-skills.test.ts packages/agent-core/test/tools/skill-tool.test.ts packages/agent-core/test/tools/skill-tool-dispatch.test.ts packages/agent-core/test/agent/skill-tool-manager.test.tspnpm --filter @moonshot-ai/agent-core run typecheck && pnpm --filter @moonshot-ai/kimi-code-sdk run typecheckgit diff --exit-code -- packages/agent-core/src/profile/default/system.md