fix: align datasource plugin environment#595
Open
7Sageer wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 18590ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Pin the datasource credential-name test to the canonical resolveKimiCodeOAuthKey so a digest drift in the standalone plugin fails CI, and drop the hardcoded plugin-name special case so every stdio plugin receives the active managed Kimi base URL / OAuth host consistently (process.env and KIMI_CODE_HOME are already shared with all plugins).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue. This PR addresses a focused datasource plugin environment mismatch.
Problem
When Kimi Code runs against a non-default managed environment, the official Kimi Datasource plugin needs to use the same service endpoint and the OAuth credentials from the matching environment-scoped credential slot. Without that, datasource calls can read the wrong token file or continue targeting the default service endpoint.
What changed
/toolsendpoint fromKIMI_CODE_BASE_URLand resolve the same environment-scoped credential name used by managed OAuth login.Verification
pnpm exec vitest run test/rpc/plugins-rpc.test.tsfrompackages/agent-corepnpm exec vitest run test/utils/kimi-datasource-plugin.test.tsfromapps/kimi-codepnpm --dir docs buildgit diff --checkNote: I ran the
gen-docsworkflow, but its documenteddocs/scripts/sync-changelog.mjsprerequisite is not present in this checkout. The affected bilingual docs page was updated directly and the docs build passes.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.