fix: Feed created_at set to now (#1467)

Author: davidgamez

functions-python/helpers/pub_sub.py

@@ -80,7 +80,7 @@ def trigger_dataset_download(
     """Publishes the feed to the configured Pub/Sub topic."""
     publisher = get_pubsub_client()
     topic_path = publisher.topic_path(PROJECT_ID, topic_name)
-    logging.debug("Publishing to Pub/Sub topic: %s", topic_path)
+    logging.info("Publishing to Pub/Sub topic: %s", topic_path)
 
     message_data = {
         "execution_id": execution_id,
@@ -100,11 +100,15 @@ def trigger_dataset_download(
         future = publisher.publish(topic_path, data=json_message.encode("utf-8"))
         future.add_done_callback(
             lambda _: logging.info(
-                "Published feed %s to dataset batch topic", feed.stable_id
+                "Published feed %s to dataset batch topic: %s",
+                feed.stable_id,
+                topic_path,
             )
         )
         future.result()
         logging.info("Message published for feed %s", feed.stable_id)
     except Exception as e:
-        logging.error("Error publishing to dataset batch topic: %s", str(e))
+        logging.error(
+            "Error publishing to dataset batch topic: %s. Error: %s", str(e), topic_path
+        )
         raise

functions-python/operations_api/src/feeds_operations/impl/feeds_operations_impl.py

@@ -373,6 +373,8 @@ async def create_gtfs_feed(
             get_execution_id(get_request_context(), "feed-created-process"),
         )
         logging.info("Created new GTFS feed with ID: %s", new_feed.stable_id)
+        refreshed = refresh_materialized_view(db_session, t_feedsearch.name)
+        logging.info("Materialized view %s refreshed: %s", t_feedsearch.name, refreshed)
         payload = OperationGtfsFeedImpl.from_orm(created_feed).model_dump()
         return JSONResponse(status_code=201, content=jsonable_encoder(payload))
 
@@ -401,5 +403,7 @@ async def create_gtfs_rt_feed(
         db_session.commit()
         created_feed = db_session.get(Gtfsrealtimefeed, new_feed.id)
         logging.info("Created new GTFS-RT feed with ID: %s", new_feed.stable_id)
+        refreshed = refresh_materialized_view(db_session, t_feedsearch.name)
+        logging.info("Materialized view %s refreshed: %s", t_feedsearch.name, refreshed)
         payload = OperationGtfsRtFeedImpl.from_orm(created_feed).model_dump()
         return JSONResponse(status_code=201, content=jsonable_encoder(payload))

functions-python/operations_api/tests/feeds_operations/impl/test_create_feeds_operations_impl_gtfs.py

@@ -63,7 +63,8 @@ def db_session():
 
 @pytest.mark.asyncio
 @patch("feeds_operations.impl.feeds_operations_impl.trigger_dataset_download")
-async def test_create_gtfs_feed_success(mock_publish_messages, db_session):
+@patch("feeds_operations.impl.feeds_operations_impl.refresh_materialized_view")
+async def test_create_gtfs_feed_success(_, mock_publish_messages, db_session):
     api = OperationsApiImpl()
     unique_url = f"https://new-feed.example.com/{uuid.uuid4()}"
     request = OperationCreateRequestGtfsFeed(
@@ -140,7 +141,8 @@ async def test_create_gtfs_feed_success(mock_publish_messages, db_session):
 
 
 @pytest.mark.asyncio
-async def test_create_gtfs_feed_duplicate_url_rejected():
+@patch("feeds_operations.impl.feeds_operations_impl.refresh_materialized_view")
+async def test_create_gtfs_feed_duplicate_url_rejected(_):
     api = OperationsApiImpl()
     # Use a URL that normalizes to the existing feed's producer_url (from feed_mdb_40)
     duplicate_url = " https://PRODUCER_URL/ "
@@ -174,7 +176,8 @@ async def test_create_gtfs_feed_duplicate_url_rejected():
 
 
 @pytest.mark.asyncio
-async def test_create_gtfs_rt_feed_success(db_session):
+@patch("feeds_operations.impl.feeds_operations_impl.refresh_materialized_view")
+async def test_create_gtfs_rt_feed_success(_, db_session):
     api = OperationsApiImpl()
     unique_url = f"https://new-feed.example.com/{uuid.uuid4()}"
     request = OperationCreateRequestGtfsRtFeed(
@@ -235,7 +238,8 @@ async def test_create_gtfs_rt_feed_success(db_session):
 
 
 @pytest.mark.asyncio
-async def test_create_gtfs_rt_feed_duplicate_url_rejected():
+@patch("feeds_operations.impl.feeds_operations_impl.refresh_materialized_view")
+async def test_create_gtfs_rt_feed_duplicate_url_rejected(_):
     api = OperationsApiImpl()
     # Use a URL that normalizes to the existing feed's producer_url (from feed_mdb_40)
     duplicate_url = " https://PRODUCER_URL/ "

liquibase/changelog.xml

@@ -82,4 +82,6 @@
     <include file="changes/feat_1249-2.sql" relativeToChangelogFile="true"/>
     <!-- Materialized view recreated to return stable_ids not UIDs -->
     <include file="changes/feat_1396.sql" relativeToChangelogFile="true"/>
+    <!-- Fixes feed.created_at default value -->
+    <include file="changes/feat_1412_2.sql" relativeToChangelogFile="true"/>
 </databaseChangeLog>

liquibase/changes/feat_1412_2.sql

@@ -0,0 +1,2 @@
+-- This scripts fixes the default value of feed.created_at. The column created_at was defaulting to'2024-02-08 00:00:00.000000' instead of NOW.
+ALTER TABLE Feed ALTER COLUMN created_at SET DEFAULT NOW();