Mock classes with functions with default dictionary args fails.

[TheZambi]

Hi, I'm trying to mock a class with an empty dictionary as a default argument of a function, but it is always throwing the following error:
"SCRIPT ERROR: Invalid type in function 'Object(GdDefaultValueDecoder.gd)::_on_type_Dictionary (Callable)'. Cannot convert argument 1 from String to Dictionary.".

After some digging, i noticed that the array function, "_on_type_Array" receives an "Variant" type and doing the same to the "_on_type_Dictionary" seems to fix the problem. Either that, or removing the default argument, leaving the argument with no default value. Is there something I'm missing with mocking these kinds of classes/functions?

[MikeSchulze]

Hi, can you share more details please.
The class with the function you want to mock and the test you have written.

[TheZambi]

Of course!

test_example_2.gd:

extends GdUnitTestSuite

func test_mock() -> void:
	var mock := mock(TestClass) as TestClass

test_class.gd:

class_name TestClass
extends Node


func test_func(test_arg: Dictionary = {}) -> void:
	print("Test print")

Output:

[MikeSchulze]

Ok looks like you found a bug ;)
continue here #629

[TheZambi]

Oh, nice (I think?). I don't know if the solution I wrote at the top of the discussion is the best, but I can't look into it right now. If you want I can dig a bit deeper when I have the time to try to find the root cause.

[TheZambi]

If you guys are looking into it and don't need me, then by all means go ahead

[MikeSchulze]

Thanks, but I'll have to take a closer look at the mocking to see why and what's going wrong, the dictionary type should actually be recognized.

[MikeSchulze]

fixed