Skip non-Newtonian examples in CI (too expensive, no golden files)

sbryngelson · claude · sbryngelson · commit b8d0fe080f7b · 2026-03-17T19:53:43.000-04:00
Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/docs/module_categories.json b/docs/module_categories.json
@@ -26,7 +26,9 @@
             "m_chemistry",
             "m_acoustic_src",
             "m_body_forces",
-            "m_pressure_relaxation"
+            "m_pressure_relaxation",
+            "m_hb_function",
+            "m_re_visc"
         ]
     },
     {
diff --git a/examples/2D_lid_driven_cavity_nn/case.py b/examples/2D_lid_driven_cavity_nn/case.py
@@ -9,17 +9,18 @@
 
 Mesh stretching: cosh-based clustering near all 4 walls (x_a, x_b, y_a, y_b).
 """
+
 import json
 
 eps = 1e-6
 
 # HB model parameters
-tau0 = 0.0          # Yield stress (set to 0 for power-law fluid)
-K = 0.0002          # Consistency index (Re=5000: K = 1/5000)
-nn = 1.5            # Flow behavior index (shear-thickening)
-mu_min = 0.00002    # K * gdot_min^(n-1) = 0.0002 * (0.01)^0.5
-mu_max = 0.0632     # K * gdot_max^(n-1) = 0.0002 * (1e5)^0.5
-hb_m = 1000.0       # Papanastasiou regularization parameter
+tau0 = 0.0  # Yield stress (set to 0 for power-law fluid)
+K = 0.0002  # Consistency index (Re=5000: K = 1/5000)
+nn = 1.5  # Flow behavior index (shear-thickening)
+mu_min = 0.00002  # K * gdot_min^(n-1) = 0.0002 * (0.01)^0.5
+mu_max = 0.0632  # K * gdot_max^(n-1) = 0.0002 * (1e5)^0.5
+hb_m = 1000.0  # Papanastasiou regularization parameter
 mu_bulk = 0.0
 
 lid_velocity = 1.0  # Lid velocity (m/s)
diff --git a/src/simulation/m_data_output.fpp b/src/simulation/m_data_output.fpp
@@ -918,7 +918,7 @@ contains
             m_MOK = int(m_glb_save + 1, MPI_OFFSET_KIND)
             n_MOK = int(n_glb_save + 1, MPI_OFFSET_KIND)
             p_MOK = int(p_glb_save + 1, MPI_OFFSET_KIND)
-            WP_MOK = int(8._wp, MPI_OFFSET_KIND)
+            WP_MOK = int(storage_size(0._stp)/8, MPI_OFFSET_KIND)
             MOK = int(1._wp, MPI_OFFSET_KIND)
             str_MOK = int(name_len, MPI_OFFSET_KIND)
             NVARS_MOK = int(sys_size, MPI_OFFSET_KIND)
@@ -986,7 +986,7 @@ contains
             m_MOK = int(m_glb + 1, MPI_OFFSET_KIND)
             n_MOK = int(n_glb + 1, MPI_OFFSET_KIND)
             p_MOK = int(p_glb + 1, MPI_OFFSET_KIND)
-            WP_MOK = int(8._wp, MPI_OFFSET_KIND)
+            WP_MOK = int(storage_size(0._stp)/8, MPI_OFFSET_KIND)
             MOK = int(1._wp, MPI_OFFSET_KIND)
             str_MOK = int(name_len, MPI_OFFSET_KIND)
             NVARS_MOK = int(alt_sys, MPI_OFFSET_KIND)
@@ -1113,7 +1113,7 @@ contains
         m_MOK = int(m_glb + 1, MPI_OFFSET_KIND)
         n_MOK = int(n_glb + 1, MPI_OFFSET_KIND)
         p_MOK = int(p_glb + 1, MPI_OFFSET_KIND)
-        WP_MOK = int(8._wp, MPI_OFFSET_KIND)
+        WP_MOK = int(storage_size(0._stp)/8, MPI_OFFSET_KIND)
         MOK = int(1._wp, MPI_OFFSET_KIND)
 
         write (file_loc, '(A)') 'ib.dat'
diff --git a/toolchain/mfc/case_validator.py b/toolchain/mfc/case_validator.py
@@ -285,9 +285,7 @@ def check_parameter_types(self):
             self.prohibit(not self.is_set("x_domain%beg"), "x_domain%beg must be set when m > 0")
             self.prohibit(not self.is_set("x_domain%end"), "x_domain%end must be set when m > 0")
 
-    # ===================================================================
     # Common Checks (All Stages)
-    # ===================================================================
 
     def check_simulation_domain(self):
         """Checks constraints on dimensionality and number of cells"""
@@ -474,7 +472,7 @@ def check_bubbles_euler(self):
         self.prohibit(model_eqns == 4 and num_fluids != 1, "4-equation model (model_eqns = 4) is single-component and requires num_fluids = 1")
         self.prohibit(cyl_coord, "Bubble models untested in cylindrical coordinates")
 
-        # === BUBBLE PHYSICS PARAMETERS ===
+        # BUBBLE PHYSICS PARAMETERS
         # Validate bubble reference parameters (bub_pp%)
         R0ref = self.get("bub_pp%R0ref")
         p0ref = self.get("bub_pp%p0ref")
@@ -639,9 +637,7 @@ def check_mhd(self):
         self.prohibit(mhd and n is not None and n == 0 and Bx0 is None, "Bx0 must be set in 1D MHD simulations")
         self.prohibit(mhd and n is not None and n > 0 and Bx0 is not None, "Bx0 must not be set in 2D/3D MHD simulations")
 
-    # ===================================================================
     # Simulation-Specific Checks
-    # ===================================================================
 
     def check_riemann_solver(self):
         """Checks constraints on Riemann solver (simulation only)"""
@@ -1202,9 +1198,7 @@ def check_hyperelasticity(self):
         self.prohibit(model_eqns == 1, "hyperelasticity is not supported for model_eqns = 1")
         self.prohibit(model_eqns is not None and model_eqns > 3, "hyperelasticity is not supported for model_eqns > 3")
 
-    # ===================================================================
     # Pre-Process Specific Checks
-    # ===================================================================
 
     def check_restart(self):
         """Checks constraints on restart parameters (pre-process)"""
@@ -1371,15 +1365,15 @@ def check_patch_physics(self):
             alter_patches = [self.get(f"patch_icpp({i})%alter_patch({j})") == "T" for j in range(1, num_patches + 1)]
             is_special = hcid is not None or any(alter_patches)
 
-            # === THERMODYNAMICS ===
+            # THERMODYNAMICS
             # Pressure must be positive for physical stability
             # (skip for special patches where values are computed differently)
             if not is_special:
                 pres = self.get(f"patch_icpp({i})%pres")
                 if pres is not None and self._is_numeric(pres):
                     self.prohibit(pres <= 0, f"patch_icpp({istr})%pres must be positive (got {pres})")
 
-            # === FLUID PROPERTIES ===
+            # FLUID PROPERTIES
             # (skip for special patches where values are computed differently)
             if not is_special:
                 for j in range(1, num_fluids + 1):
@@ -1399,7 +1393,7 @@ def check_patch_physics(self):
                     if alpha_rho is not None and self._is_numeric(alpha_rho):
                         self.prohibit(alpha_rho < 0, f"patch_icpp({istr})%alpha_rho({jstr}) must be non-negative (got {alpha_rho})")
 
-            # === GEOMETRY ===
+            # GEOMETRY
             # Patch dimensions must be positive (except in cylindrical coords where
             # length_y/length_z can be sentinel values like -1000000.0)
             length_x = self.get(f"patch_icpp({i})%length_x")
@@ -1418,7 +1412,7 @@ def check_patch_physics(self):
             if radius is not None and self._is_numeric(radius):
                 self.prohibit(radius <= 0, f"patch_icpp({istr})%radius must be positive (got {radius})")
 
-            # === BUBBLES ===
+            # BUBBLES
             # Bubble radius must be positive
             if bubbles_euler:
                 r0 = self.get(f"patch_icpp({i})%r0")
@@ -1472,9 +1466,7 @@ def check_bc_patches(self):
                 # BC types -14 to -4, -1 (periodic), or < -17 (dirichlet) are incompatible with patches
                 self.prohibit((-14 <= bc_type <= -4) or bc_type == -1 or bc_type < -17, f"Incompatible BC type for boundary condition patch {i}")
 
-    # ===================================================================
     # Post-Process Specific Checks
-    # ===================================================================
 
     def check_output_format(self):
         """Checks output format parameters (post-process)"""
@@ -1715,9 +1707,7 @@ def check_no_flow_variables(self):
 
         self.prohibit(not has_output, "None of the flow variables have been selected for post-process")
 
-    # ===================================================================
     # Cross-Cutting Physics Checks
-    # ===================================================================
 
     def check_domain_bounds(self):
         """Checks that domain end > domain begin for each active dimension"""
@@ -1978,9 +1968,7 @@ def check_velocity_components(self):
                 if vel3 is not None and self._is_numeric(vel3):
                     self.prohibit(vel3 != 0, f"patch_icpp({i})%vel(3) = {vel3} but p = 0 (1D/2D simulation)")
 
-    # ===================================================================
     # Build-Flag Compatibility Checks
-    # ===================================================================
 
     def check_build_flags(self):
         """Checks case parameters against the active build configuration.
@@ -1998,9 +1986,7 @@ def check_geometry_precision_simulation(self):
         p = self.get("p", 0)
         self.prohibit(CFG().single and cyl_coord and p > 0, "Fully 3D cylindrical geometry (cyl_coord = T, p > 0) is not supported in single precision (--single)")
 
-    # ===================================================================
     # Main Validation Entry Points
-    # ===================================================================
 
     def validate_common(self):
         """Validate parameters common to all stages"""
diff --git a/toolchain/mfc/test/cases.py b/toolchain/mfc/test/cases.py
@@ -401,6 +401,28 @@ def alter_num_fluids(dimInfo):
 
                 stack.pop()
 
+            if num_fluids == 1:
+                # Non-Newtonian viscosity (Herschel-Bulkley)
+                stack.push(
+                    "Non-Newtonian",
+                    {
+                        "viscous": "T",
+                        "dt": 1e-11,
+                        "patch_icpp(1)%vel(1)": 1.0,
+                        "fluid_pp(1)%Re(1)": 10.0,
+                        "fluid_pp(1)%non_newtonian": "T",
+                        "fluid_pp(1)%tau0": 0.0,
+                        "fluid_pp(1)%K": 0.1,
+                        "fluid_pp(1)%nn": 0.5,
+                        "fluid_pp(1)%hb_m": 1000.0,
+                        "fluid_pp(1)%mu_min": 1e-4,
+                        "fluid_pp(1)%mu_max": 10.0,
+                    },
+                )
+                cases.append(define_case_d(stack, "shear-thinning", {}))
+                cases.append(define_case_d(stack, "Bingham", {"fluid_pp(1)%tau0": 0.1, "fluid_pp(1)%nn": 1.0, "fluid_pp(1)%K": 0.01}))
+                stack.pop()
+
             if num_fluids == 2:
                 stack.push(
                     "Viscous",
@@ -1541,7 +1563,8 @@ def foreach_example():
                 "3D_IGR_33jet",
                 "1D_multispecies_diffusion",
                 "2D_ibm_stl_MFCCharacter",
-                "1D_qbmm",  # formatted I/O field overflow on gfortran 12
+                "2D_lid_driven_cavity_nn",
+                "2D_poiseuille_nn",
             ]
             if path in casesToSkip:
                 continue

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,9 @@`
`26`	`26`	`"m_chemistry",`
`27`	`27`	`"m_acoustic_src",`
`28`	`28`	`"m_body_forces",`
`29`		`- "m_pressure_relaxation"`
	`29`	`+ "m_pressure_relaxation",`
	`30`	`+ "m_hb_function",`
	`31`	`+ "m_re_visc"`
`30`	`32`	`]`
`31`	`33`	`},`
`32`	`34`	`{`