chore: fix qlty config a bit

Author: leaftail1880

.qlty/configs/.yamllint.yaml

@@ -2,7 +2,7 @@ rules:
   document-start: disable
   quoted-strings:
     required: only-when-needed
-    extra-allowed: ["{|}"]
+    extra-allowed: ['{|}']
   key-duplicates: {}
   octal-values:
     forbid-implicit-octal: true

.qlty/qlty.toml

@@ -44,6 +44,9 @@ exclude_patterns = [
   "tools/**",
   "*.config.ts",
   "src/modules/world-edit/**",
+  "src/lib/utils/sprintf.ts",
+  "src/lib/utils/later.ts",
+  "src/lib/vector.ts",
   "items/**",
   "*.json",
   "functions/**",
@@ -65,19 +68,20 @@ test_patterns = [
 
 [smells]
 mode = "comment"
-
-[smells.return_statements]
-enabled = false
+return_statements.enabled = false
+function_parameters.threshold = 10
+function_complexity.threshold = 40
+file_complexity.threshold = 100
 
 [[source]]
 name = "default"
 default = true
 
-[[plugin]]
-name = "osv-scanner"
+# [[plugin]]
+# name = "osv-scanner"
 
-[[plugin]]
-name = "radarlint-js"
+# [[plugin]]
+# name = "radarlint-js"
 
 [[plugin]]
 name = "ripgrep"

src/lib/chunk-query.test.ts

@@ -565,4 +565,3 @@ function inspectChunks(query: ChunkQuery, dimensionType: DimensionType = 'overwo
     return 'Empty'
   }
 }
-

src/lib/region/areas/cut.test.ts

@@ -248,4 +248,3 @@ describe('sphere', () => {
     expect(vOrder).toEqual(otherVOrder)
   })
 })
-

src/lib/region/areas/sphere.test.ts

@@ -176,4 +176,3 @@ describe('sphere', () => {
     expect(vOrder).toEqual(otherVOrder)
   })
 })
-

src/lib/region/structure.ts

@@ -36,7 +36,6 @@ export class RegionStructure {
 
   save(): void | Promise<void> {
     this.validateArea()
-    // TODO Test that changin order of edges does not break structure
     world.structureManager.createFromWorld(this.id, this.region.dimension, ...this.region.area.edges, {
       saveMode: StructureSaveMode.World,
       includeEntities: false,

src/lib/rpg/loot-table.test.ts

@@ -63,4 +63,3 @@ describe('loot table random cost', () => {
     `)
   })
 })
-

src/modules/commands/player.ts

@@ -1,5 +1,3 @@
-// TODO Group actions (e.g. mute, ban, invsee, wpchest etc)
-
 import { Player } from '@minecraft/server'
 import { is, Portal, stringify } from 'lib'
 import { Achievement } from 'lib/achievements/achievement'

src/modules/places/anarchy/quartz.ts

@@ -2,6 +2,7 @@ import { ItemStack, system } from '@minecraft/server'
 
 import { MinecraftBlockTypes, MinecraftEffectTypes, MinecraftItemTypes } from '@minecraft/vanilla-data'
 import { isKeyof, ms } from 'lib'
+import { RegionEvents } from 'lib/region/events'
 import { actionGuard, ActionGuardOrder, disableAdventureNear, Region, RegionPermissions } from 'lib/region/index'
 import { ScheduleBlockPlace } from 'lib/scheduled-block-place'
 import { TechCity } from '../tech-city/tech-city'
@@ -42,29 +43,28 @@ system.runPlayerInterval(
   player => {
     const { typeId } = player.mainhand()
 
-    // TODO Maybe check for region or inv type
     if (typeId && isKeyof(typeId, HoeEffectLevels)) {
-      player.addEffect(MinecraftEffectTypes.Haste, 2, {
-        amplifier: HoeEffectLevels[typeId],
-        showParticles: false,
-      })
+      const inQuartzMine = RegionEvents.playerInRegionsCache
+        .get(player)
+        ?.some(e => e === TechCity.safeArea || e instanceof QuartzMineRegion)
+
+      if (inQuartzMine) {
+        player.addEffect(MinecraftEffectTypes.Haste, 2, {
+          amplifier: HoeEffectLevels[typeId],
+          showParticles: false,
+        })
+      }
     }
   },
   'quartz feature, hoe haste effect',
   2,
 )
 
-actionGuard((player, region, ctx) => {
-  if (
-    ctx.type !== 'break' ||
-    (region !== TechCity.safeArea && !(region instanceof QuartzMineRegion)) ||
-    // Check block
-    ctx.event.block.typeId !== quartzTypeId ||
-    // Check item
-    !ctx.event.itemStack?.typeId ||
-    !(ctx.event.itemStack.typeId in HoeEffectLevels)
-  )
-    return
+actionGuard((_, region, ctx) => {
+  if (ctx.type !== 'break') return
+  if (region !== TechCity.safeArea && !(region instanceof QuartzMineRegion)) return
+  if (ctx.event.block.typeId !== quartzTypeId) return
+  if (!ctx.event.itemStack?.typeId || !(ctx.event.itemStack.typeId in HoeEffectLevels)) return
 
   ScheduleBlockPlace.setBlock(ctx.event.block, ms.from('min', 2))
 

src/modules/places/stone-quarry/barman.ts

@@ -1,5 +1,10 @@
 import { ItemStack } from '@minecraft/server'
-import { MinecraftItemTypes as i } from '@minecraft/vanilla-data'
+import {
+  MinecraftPotionEffectTypes as e,
+  MinecraftItemTypes as i,
+  MinecraftPotionLiquidTypes as lt,
+  MinecraftPotionModifierTypes as mt,
+} from '@minecraft/vanilla-data'
 import { Group } from 'lib/rpg/place'
 import { MoneyCost } from 'lib/shop/cost'
 import { ShopNpc } from 'lib/shop/npc'
@@ -13,26 +18,42 @@ export class Barman extends ShopNpc {
       form.itemStack(new ItemStack(i.MilkBucket), new MoneyCost(10))
       form.itemStack(new ItemStack(i.HoneyBottle), new MoneyCost(20))
 
-      const pivo = new ItemStack(i.GlassBottle)
-      pivo.nameTag = 'Пиво'
-      form.itemStack(pivo, new MoneyCost(1))
+      form.itemStack(
+        ItemStack.createPotion({ effect: e.FireResistance, liquid: lt.Lingering }).setInfo('Квас', undefined),
+        new MoneyCost(40),
+      )
 
-      const kvac = new ItemStack(i.GlassBottle)
-      kvac.nameTag = 'Квас'
-      form.itemStack(kvac, new MoneyCost(1))
+      form.itemStack(
+        ItemStack.createPotion({ effect: e.FireResistance, liquid: lt.Lingering, modifier: mt.Long }).setInfo(
+          'Пиво',
+          undefined,
+        ),
+        new MoneyCost(50),
+      )
 
-      const sidr = new ItemStack(i.GlassBottle)
-      sidr.nameTag = 'Сидр'
-      form.itemStack(sidr, new MoneyCost(1))
+      form.itemStack(
+        ItemStack.createPotion({ effect: e.Invisibility, liquid: lt.Lingering, modifier: mt.Long }).setInfo(
+          'Сидр',
+          undefined,
+        ),
+        new MoneyCost(500),
+      )
 
-      const sh = new ItemStack(i.GlassBottle)
-      sh.nameTag = 'Настойка из шпината'
-      form.itemStack(sh, new MoneyCost(1))
+      form.itemStack(
+        ItemStack.createPotion({ effect: e.WaterBreath, liquid: lt.Lingering, modifier: mt.Long }).setInfo(
+          'Настойка из шпината',
+          undefined,
+        ),
+        new MoneyCost(300),
+      )
 
-      const wine = new ItemStack(i.GlassBottle)
-      wine.nameTag = 'Вино'
-      form.itemStack(wine, new MoneyCost(1))
-      // TODO On potion API expansion add WINE
+      form.itemStack(
+        ItemStack.createPotion({ effect: e.TurtleMaster, liquid: lt.Lingering, modifier: mt.Long }).setInfo(
+          'Вино',
+          undefined,
+        ),
+        new MoneyCost(1000),
+      )
     })
   }
 }