Remove deprecated methods from SQLFragment (#235)

labkey-jeckels · web-flow · commit 4457bba727c0 · 2025-09-29T09:07:17.000-07:00
diff --git a/hdrl/src/org/labkey/hdrl/query/InboundRequestUpdateService.java b/hdrl/src/org/labkey/hdrl/query/InboundRequestUpdateService.java
@@ -148,7 +148,7 @@ public static void validateUniqueness(Integer requestId) throws QueryUpdateServi
     private static List<String> findDuplicates(Integer requestId, String fields)
     {
         SQLFragment sql = new SQLFragment("SELECT ")
-                .append(fields).append(" FROM hdrl.inboundspecimen WHERE inboundrequestid = ").append(requestId);
+                .append(fields).append(" FROM hdrl.inboundspecimen WHERE inboundrequestid = ?").add(requestId);
         for (String field : fields.split(", "))
         {
             sql.append(" AND ").append(field).append(" IS NOT NULL ");

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ public static void validateUniqueness(Integer requestId) throws QueryUpdateServi`
`148`	`148`	`private static List<String> findDuplicates(Integer requestId, String fields)`
`149`	`149`	`{`
`150`	`150`	`SQLFragment sql = new SQLFragment("SELECT ")`
`151`		`- .append(fields).append(" FROM hdrl.inboundspecimen WHERE inboundrequestid = ").append(requestId);`
	`151`	`+ .append(fields).append(" FROM hdrl.inboundspecimen WHERE inboundrequestid = ?").add(requestId);`
`152`	`152`	`for (String field : fields.split(", "))`
`153`	`153`	`{`
`154`	`154`	`sql.append(" AND ").append(field).append(" IS NOT NULL ");`