Skip to content

Commit e56a8ff

Browse files
Merge 24.3 to develop
2 parents 58a09de + 0b53938 commit e56a8ff

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

OConnorExperiments/src/org/labkey/oconnorexperiments/query/ExperimentsTable.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ public void addColumns()
197197
//UserSchema targetSchema = getUserSchema().getContainer().isWorkbook() ? new OConnorExperimentsUserSchema(getUserSchema().getUser(), getUserSchema().getContainer().getParent()) : getUserSchema();
198198
MultiValuedForeignKey parentExperimentsFk = new MultiValuedForeignKey(
199199
QueryForeignKey
200-
.from(getUserSchema(), getContainerFilter())
200+
.from(getUserSchema(), getContainer().isWorkbook() ? ContainerFilter.Type.CurrentAndFirstChildren.create(getContainer().getParent(), getUserSchema().getUser()) : getContainerFilter())
201201
.schema(OConnorExperimentsUserSchema.NAME, getContainer().isWorkbook() ? getContainer().getParent() : getContainer())
202202
.to(OConnorExperimentsUserSchema.Table.ParentExperiments.name(), "Container", null),
203203
"ParentExperiment");

OConnorExperiments/test/src/org/labkey/test/tests/OConnorExperimentTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,10 @@ public void testSteps()
114114
updateViaExperimentWebpart(0, null, "type3", "1,2");
115115
verifyExperimentWebpart(0, "updated description 3", "type3", 1, 2);
116116

117+
// Make sure the values round-trip if they're not explicitly set
118+
updateViaExperimentWebpart(0, null, null, null);
119+
verifyExperimentWebpart(0, "updated description 3", "type3", 1, 2);
120+
117121
testBulkUpdate();
118122

119123
// delete via the webpart

0 commit comments

Comments
 (0)