Do not write an empty <ModificationList> element when there are no modifications with Unimod Ids: (#500)

vagisha · web-flow · commit fe000c32ec5f · 2025-02-04T09:03:12.000-08:00
diff --git a/panoramapublic/src/org/labkey/panoramapublic/proteomexchange/PxXmlWriter.java b/panoramapublic/src/org/labkey/panoramapublic/proteomexchange/PxXmlWriter.java
@@ -391,7 +391,7 @@ void writeModificationList(Status validationStatus) throws PxException
          */
         Element mod_list = new Element("ModificationList");
         var mods = validationStatus.getModifications();
-        if(mods.size() == 0)
+        if(mods.size() == 0 || mods.stream().noneMatch(Modification::isValid))
         {
             mod_list.addChild(new CvParamElement("MS", "MS:1002864", "No PTMs are included in the dataset"));
         }

Original file line number	Diff line number	Diff line change
`@@ -391,7 +391,7 @@ void writeModificationList(Status validationStatus) throws PxException`
`391`	`391`	`*/`
`392`	`392`	`Element mod_list = new Element("ModificationList");`
`393`	`393`	`var mods = validationStatus.getModifications();`
`394`		`- if(mods.size() == 0)`
	`394`	`+ if(mods.size() == 0 \|\| mods.stream().noneMatch(Modification::isValid))`
`395`	`395`	`{`
`396`	`396`	`mod_list.addChild(new CvParamElement("MS", "MS:1002864", "No PTMs are included in the dataset"));`
`397`	`397`	`}`