Change condition to use toolIcon == null to avoid scanning the entire tool ZIP

vagisha · Copilot · web-flow · commit 767b8bff37b3 · 2026-03-16T14:00:44.000-07:00
Co-authored-by: Copilot Autofix powered by AI &lt;175728472+Copilot@users.noreply.github.com&gt;
diff --git a/SkylineToolsStore/src/org/labkey/skylinetoolsstore/SkylineToolsStoreController.java b/SkylineToolsStore/src/org/labkey/skylinetoolsstore/SkylineToolsStoreController.java
@@ -176,7 +176,7 @@ protected SkylineTool getToolFromZip(MultipartFile zip) throws IOException
         {
             ZipEntry zipEntry;
             while ((zipEntry = zipStream.getNextEntry()) != null &&
-                    (tool == null || tool.getIcon() == null))
+                    (tool == null || toolIcon == null))
             {
                 String entryLower = zipEntry.getName().toLowerCase();
                 if (entryLower.startsWith("tool-inf/") && !entryLower.startsWith("tool-inf/docs/"))

Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,7 @@ protected SkylineTool getToolFromZip(MultipartFile zip) throws IOException`
`176`	`176`	`{`
`177`	`177`	`ZipEntry zipEntry;`
`178`	`178`	`while ((zipEntry = zipStream.getNextEntry()) != null &&`
`179`		`- (tool == null \|\| tool.getIcon() == null))`
	`179`	`+ (tool == null \|\| toolIcon == null))`
`180`	`180`	`{`
`181`	`181`	`String entryLower = zipEntry.getName().toLowerCase();`
`182`	`182`	`if (entryLower.startsWith("tool-inf/") && !entryLower.startsWith("tool-inf/docs/"))`