Skip to content

Commit ff2f8f7

Browse files
authored
Fb 7140 sample set to sample type (#35)
1 parent 4eb2f68 commit ff2f8f7

File tree

4 files changed

+27
-28
lines changed

4 files changed

+27
-28
lines changed

laboratory/resources/web/laboratory/utils.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ Laboratory.Utils = new function(){
1313
},
1414

1515
/**
16-
* The purpose of this helper is to provide a listing of all items to display in the laboratory module navigation pages. It draws from
17-
* assays, sample sets, and other other NavItems that have been registered with LaboratoryService.
16+
* The purpose of this helper is to provide a listing of all items to display in the laboratory module navigation pages. It draws from
17+
* assays, sample types, and other other NavItems that have been registered with LaboratoryService.
1818
* @param [config.types] Optional.
1919
* @param [config.includeHidden] Optional. If true, non-visible items will be included.
2020
* @param config.success Success callback. Will be passed a single object as an argument with the following properties

laboratory/src/org/labkey/laboratory/LaboratoryModule.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ protected void doStartupAfterSpringConfig(ModuleContext moduleContext)
156156
RoleManager.registerRole(new LaboratoryAdminRole());
157157

158158
LaboratoryService.get().registerDataProvider(new LaboratoryDataProvider(this));
159-
LaboratoryService.get().registerDataProvider(new SampleSetDataProvider());
159+
LaboratoryService.get().registerDataProvider(new SampleTypeDataProvider());
160160
LaboratoryService.get().registerDataProvider(new ExtraDataSourcesDataProvider(this));
161161

162162
DetailsURL details = DetailsURL.fromString("/laboratory/siteLabSettings.view");

laboratory/src/org/labkey/laboratory/SampleSetDataProvider.java renamed to laboratory/src/org/labkey/laboratory/SampleTypeDataProvider.java

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
import org.labkey.api.data.Container;
2222
import org.labkey.api.data.SimpleFilter;
2323
import org.labkey.api.data.TableInfo;
24-
import org.labkey.api.exp.api.ExpSampleSet;
25-
import org.labkey.api.exp.api.ExperimentService;
24+
import org.labkey.api.exp.api.ExpSampleType;
25+
import org.labkey.api.exp.api.SampleTypeService;
2626
import org.labkey.api.laboratory.AbstractDataProvider;
2727
import org.labkey.api.laboratory.LaboratoryService;
2828
import org.labkey.api.laboratory.QueryCountNavItem;
@@ -47,13 +47,12 @@
4747
* Date: 10/8/12
4848
* Time: 9:06 AM
4949
*/
50-
public class SampleSetDataProvider extends AbstractDataProvider
50+
public class SampleTypeDataProvider extends AbstractDataProvider
5151
{
52-
public static final String NAME = "SampleSetDataProvider";
52+
public static final String NAME = "SampleTypeDataProvider";
5353

54-
public SampleSetDataProvider()
54+
public SampleTypeDataProvider()
5555
{
56-
5756
}
5857

5958
@Override
@@ -77,12 +76,12 @@ public List<NavItem> getDataNavItems(Container c, User u)
7776
@Override
7877
public List<NavItem> getSampleNavItems(Container c, User u)
7978
{
80-
//also append all sample sets in this container
79+
//also append all sample types in this container
8180
List<NavItem> navItems = new ArrayList<NavItem>();
8281

83-
for (ExpSampleSet ss : ExperimentService.get().getSampleSets(c, u, true))
82+
for (ExpSampleType st : SampleTypeService.get().getSampleTypes(c, u, true))
8483
{
85-
navItems.add(new SampleSetNavItem(this, LaboratoryService.NavItemCategory.samples, ss));
84+
navItems.add(new SampleTypeNavItem(this, LaboratoryService.NavItemCategory.samples, st));
8685
}
8786
return navItems;
8887
}
@@ -116,12 +115,12 @@ public Module getOwningModule()
116115
public List<SummaryNavItem> getSummary(Container c, User u)
117116
{
118117
List<SummaryNavItem> items = new ArrayList<>();
119-
for (ExpSampleSet ss : ExperimentService.get().getSampleSets(c, u, true))
118+
for (ExpSampleType st : SampleTypeService.get().getSampleTypes(c, u, true))
120119
{
121-
SampleSetNavItem nav = new SampleSetNavItem(this, LaboratoryService.NavItemCategory.samples, ss);
120+
SampleTypeNavItem nav = new SampleTypeNavItem(this, LaboratoryService.NavItemCategory.samples, st);
122121
if (nav.isVisible(c, u))
123122
{
124-
items.add(new QueryCountNavItem(this, "Samples", ss.getName(), LaboratoryService.NavItemCategory.samples, "Samples", ss.getName()));
123+
items.add(new QueryCountNavItem(this, "Samples", st.getName(), LaboratoryService.NavItemCategory.samples, "Samples", st.getName()));
125124
}
126125
}
127126

@@ -132,18 +131,18 @@ public List<SummaryNavItem> getSummary(Container c, User u)
132131
public List<NavItem> getSubjectIdSummary(Container c, User u, String subjectId)
133132
{
134133
List<NavItem> items = new ArrayList<NavItem>();
135-
for (ExpSampleSet ss : ExperimentService.get().getSampleSets(c, u, true))
134+
for (ExpSampleType st : SampleTypeService.get().getSampleTypes(c, u, true))
136135
{
137136
UserSchema us = QueryService.get().getUserSchema(u, c, "Samples");
138137
if (us != null)
139138
{
140-
TableInfo ti = us.getTable(ss.getName());
139+
TableInfo ti = us.getTable(st.getName());
141140
if (ti != null)
142141
{
143142
ColumnInfo ci = getSubjectColumn(ti);
144143
if (ci != null)
145144
{
146-
QueryCountNavItem qc = new QueryCountNavItem(this, "Samples", ss.getName(), LaboratoryService.NavItemCategory.samples, "Samples", ss.getName());
145+
QueryCountNavItem qc = new QueryCountNavItem(this, "Samples", st.getName(), LaboratoryService.NavItemCategory.samples, "Samples", st.getName());
147146
qc.setFilter(new SimpleFilter(FieldKey.fromString(ci.getName()), subjectId));
148147
items.add(qc);
149148
}

laboratory/src/org/labkey/laboratory/SampleSetNavItem.java renamed to laboratory/src/org/labkey/laboratory/SampleTypeNavItem.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
package org.labkey.laboratory;
1717

1818
import org.labkey.api.data.Container;
19-
import org.labkey.api.exp.api.ExpSampleSet;
19+
import org.labkey.api.exp.api.ExpSampleType;
2020
import org.labkey.api.exp.api.ExperimentUrls;
2121
import org.labkey.api.exp.query.SamplesSchema;
2222
import org.labkey.api.laboratory.AbstractImportingNavItem;
@@ -35,14 +35,14 @@
3535
* Date: 10/1/12
3636
* Time: 8:51 AM
3737
*/
38-
public class SampleSetNavItem extends AbstractImportingNavItem
38+
public class SampleTypeNavItem extends AbstractImportingNavItem
3939
{
40-
private ExpSampleSet _sampleSet;
40+
private final ExpSampleType _sampleType;
4141

42-
public SampleSetNavItem(DataProvider provider, LaboratoryService.NavItemCategory itemType, ExpSampleSet sampleSet)
42+
public SampleTypeNavItem(DataProvider provider, LaboratoryService.NavItemCategory itemType, ExpSampleType sampleType)
4343
{
44-
super(provider, sampleSet.getName(), sampleSet.getName(), itemType, LaboratoryService.NavItemCategory.samples.name());
45-
_sampleSet = sampleSet;
44+
super(provider, sampleType.getName(), sampleType.getName(), itemType, LaboratoryService.NavItemCategory.samples.name());
45+
_sampleType = sampleType;
4646
}
4747

4848
@Override
@@ -56,7 +56,7 @@ public boolean getDefaultVisibility(Container c, User u)
5656
{
5757
//by default, only show if defined in current container
5858
Container toCompare = c.isWorkbook() ? c.getParent() : c;
59-
return _sampleSet.getContainer().equals(toCompare);
59+
return _sampleType.getContainer().equals(toCompare);
6060
}
6161

6262
@Override
@@ -65,19 +65,19 @@ public ActionURL getImportUrl(Container c, User u)
6565
if (!c.hasPermission(u, InsertPermission.class))
6666
return null;
6767

68-
ActionURL url = PageFlowUtil.urlProvider(ExperimentUrls.class).getImportSamplesURL(c, _sampleSet.getName());
68+
ActionURL url = PageFlowUtil.urlProvider(ExperimentUrls.class).getImportSamplesURL(c, _sampleType.getName());
6969
return url;
7070
}
7171

7272
@Override
7373
public ActionURL getSearchUrl(Container c, User u)
7474
{
75-
return PageFlowUtil.urlProvider(LaboratoryUrls.class).getSearchUrl(c, SamplesSchema.SCHEMA_NAME, _sampleSet.getName());
75+
return PageFlowUtil.urlProvider(LaboratoryUrls.class).getSearchUrl(c, SamplesSchema.SCHEMA_NAME, _sampleType.getName());
7676
}
7777

7878
@Override
7979
public ActionURL getBrowseUrl(Container c, User u)
8080
{
81-
return QueryService.get().urlFor(u, c, QueryAction.executeQuery, SamplesSchema.SCHEMA_NAME, _sampleSet.getName());
81+
return QueryService.get().urlFor(u, c, QueryAction.executeQuery, SamplesSchema.SCHEMA_NAME, _sampleType.getName());
8282
}
8383
}

0 commit comments

Comments
 (0)