Skip to content

Commit d2a7a54

Browse files
Ignore mutating sql warning while running LabSummaryNotification (#57)
1 parent 78eca09 commit d2a7a54

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

LDK/src/org/labkey/ldk/notification/SiteSummaryNotification.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import org.apache.log4j.Logger;
2323
import org.json.JSONArray;
2424
import org.json.JSONObject;
25+
import org.labkey.api.action.SpringActionController;
2526
import org.labkey.api.audit.AuditLogService;
2627
import org.labkey.api.audit.AuditTypeProvider;
2728
import org.labkey.api.data.CompareType;
@@ -168,7 +169,12 @@ private void saveValues(Container c, Map<String, String> saved, Map<String, Stri
168169
newValues.put(lastSave, String.valueOf(new Date().getTime()));
169170
map.putAll(newValues);
170171

171-
map.save();
172+
// this is recording when the report was last run, which is similar to audit logging and similar activities
173+
// that we are comfortable treating as non-mutating.
174+
try (var ignored = SpringActionController.ignoreSqlUpdates())
175+
{
176+
map.save();
177+
}
172178
}
173179

174180
@Override

laboratory/src/org/labkey/laboratory/notification/LabSummaryNotification.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import org.apache.log4j.Logger;
66
import org.json.JSONArray;
77
import org.json.JSONObject;
8+
import org.labkey.api.action.SpringActionController;
89
import org.labkey.api.data.Container;
910
import org.labkey.api.data.CoreSchema;
1011
import org.labkey.api.data.DbSchema;
@@ -116,7 +117,12 @@ private void saveValues(Container c, Map<String, String> saved, Map<String, Stri
116117
newValues.put(lastSave, String.valueOf(new Date().getTime()));
117118
map.putAll(newValues);
118119

119-
map.save();
120+
// this is recording when the report was last run, which is similar to audit logging and similar activities
121+
// that we are comfortable treating as non-mutating.
122+
try (var ignored = SpringActionController.ignoreSqlUpdates())
123+
{
124+
map.save();
125+
}
120126
}
121127

122128
private String getPctChange(Long oldVal, Long newVal, double threshold)

0 commit comments

Comments
 (0)