Skip to content

Commit 2fca011

Browse files
committed
Debug TeamCity failure
1 parent c7a85a6 commit 2fca011

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

laboratory/resources/web/laboratory/panel/ProjectFilterType.js

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,11 @@ Ext4.define('Laboratory.panel.ProjectFilterType', {
5252
items: [{
5353
boxLabel: 'Include if subject was ever a member of the project/group',
5454
inputValue: 'allProjects',
55-
checked: ctx.projectFilterMode != 'overlappingProjects'
55+
checked: ctx.projectFilterMode !== 'overlappingProjects'
5656
},{
5757
boxLabel: 'Include only if the sample date overlaps with assignment to that project/group',
5858
inputValue: 'overlappingProjects',
59-
checked: ctx.projectFilterMode == 'overlappingProjects'
59+
checked: ctx.projectFilterMode === 'overlappingProjects'
6060
}]
6161
}]
6262
});
@@ -79,7 +79,7 @@ Ext4.define('Laboratory.panel.ProjectFilterType', {
7979

8080
var filters = this.getFilters();
8181
var report = tab.report;
82-
var projectFieldName = (filters.projectFilterMode == 'overlappingProjects') ? report.overlappingProjectsFieldName : report.allProjectsFieldName;
82+
var projectFieldName = (filters.projectFilterMode === 'overlappingProjects') ? report.overlappingProjectsFieldName : report.allProjectsFieldName;
8383
if (!projectFieldName){
8484
if (filters.projectFilterMode === 'overlappingProjects' && !report.overlappingProjectsFieldName){
8585
projectFieldName = report.allProjectsFieldName;
@@ -100,6 +100,14 @@ Ext4.define('Laboratory.panel.ProjectFilterType', {
100100
}
101101
}
102102

103+
if (!filters.projects || !filters.projects.length) {
104+
LDK.Utils.logToServer({
105+
message: 'ProjectFilterType.getFilterArray() called with empty value: ' + filters.projects + ' / ' + this.getProjects(),
106+
level: 'ERROR',
107+
includeContext: true
108+
});
109+
}
110+
103111
var fieldName = filters.projects[0].replaceAll('/', '$S');
104112
projectFieldName = projectFieldName + '/' + fieldName + '::lastStartDate';
105113
filterArray.nonRemovable.push(LABKEY.Filter.create(projectFieldName, null, LABKEY.Filter.Types.NONBLANK));

0 commit comments

Comments
 (0)