Add validation on null DemographicsProvider names

bbimber · bbimber · commit 2e4100e3482a · 2024-02-29T15:47:39.000-08:00
diff --git a/laboratory/src/org/labkey/laboratory/LaboratoryServiceImpl.java b/laboratory/src/org/labkey/laboratory/LaboratoryServiceImpl.java
@@ -696,6 +696,11 @@ public List<DemographicsProvider> getDemographicsProviders(final Container c, fi
     @Override
     public @Nullable DemographicsProvider getDemographicsProviderByName(Container c, User u, String name)
     {
+        if (name == null)
+        {
+            throw new IllegalArgumentException("The DemographicsProvider name cannot be null");
+        }
+
         for (DemographicsProvider d : getDemographicsProviders(c, u))
         {
             if (name.equals(d.getLabel()))

Original file line number	Diff line number	Diff line change
`@@ -696,6 +696,11 @@ public List<DemographicsProvider> getDemographicsProviders(final Container c, fi`
`696`	`696`	`@Override`
`697`	`697`	`public @Nullable DemographicsProvider getDemographicsProviderByName(Container c, User u, String name)`
`698`	`698`	`{`
	`699`	`+ if (name == null)`
	`700`	`+ {`
	`701`	`+ throw new IllegalArgumentException("The DemographicsProvider name cannot be null");`
	`702`	`+ }`
	`703`	`+`
`699`	`704`	`for (DemographicsProvider d : getDemographicsProviders(c, u))`
`700`	`705`	`{`
`701`	`706`	`if (name.equals(d.getLabel()))`