Skip to content

Commit 046be72

Browse files
committed
Fix for multi subject search
1 parent e80bb14 commit 046be72

File tree

1 file changed

+14
-12
lines changed

1 file changed

+14
-12
lines changed

LDK/resources/web/LDK/panel/SingleSubjectFilterType.js

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -200,25 +200,27 @@ Ext4.define('LDK.panel.SingleSubjectFilterType', {
200200

201201
if (subjIndex !== -1) {
202202
this.notFound.splice(subjIndex, 1);
203-
if (this.caseInsensitive) // Ensure case mismatch corrected
204-
this.subjects.splice(subjIndex, 1, row[this.aliasTable.aliasColumn]);
205203
}
206204

207-
// Resolve aliases
208-
if (row[this.aliasTable.idColumn] !== row[this.aliasTable.aliasColumn]) {
209-
var index = this.subjects.indexOf(row[this.aliasTable.aliasColumn]);
210-
if (index === -1 && this.caseInsensitive) {
211-
for (var i = 0; i < this.subjects.length; i++) {
212-
if (row[this.aliasTable.aliasColumn].toLowerCase() === this.subjects[i].toLowerCase()) {
213-
index = i;
214-
break;
215-
}
205+
var index = this.subjects.indexOf(row[this.aliasTable.aliasColumn]);
206+
if (index === -1 && this.caseInsensitive) {
207+
for (var i = 0; i < this.subjects.length; i++) {
208+
if (row[this.aliasTable.aliasColumn].toLowerCase() === this.subjects[i].toLowerCase()) {
209+
index = i;
210+
break;
216211
}
217212
}
213+
}
214+
215+
if (index !== -1) {
216+
this.subjects.splice(index, 1, row[this.aliasTable.idColumn]);
217+
}
218+
219+
// Resolve aliases
220+
if (row[this.aliasTable.idColumn] !== row[this.aliasTable.aliasColumn]) {
218221

219222
if (index !== -1) {
220223
this.aliases[row[this.aliasTable.aliasColumn]] = [row[this.aliasTable.idColumn]];
221-
this.subjects.splice(index, 1, row[this.aliasTable.idColumn]);
222224
}
223225
// In case an alias matches multiple ID's
224226
else {

0 commit comments

Comments
 (0)