Skip to content

Commit fa471aa

Browse files
committed
Support maxLibrarySizeRatio for nimble
1 parent 98cfa80 commit fa471aa

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

singlecell/resources/chunks/AppendNimble.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ for (datasetId in names(seuratObjects)) {
1111
seuratObj <- readSeuratRDS(seuratObjects[[datasetId]])
1212

1313
for (genomeId in names(nimbleGenomes)) {
14-
seuratObj <- Rdiscvr::DownloadAndAppendNimble(seuratObject = seuratObj, allowableGenomes = genomeId, targetAssayName = nimbleGenomes[[genomeId]], enforceUniqueFeatureNames = TRUE, dropAmbiguousFeatures = !retainAmbiguousFeatures)
14+
seuratObj <- Rdiscvr::DownloadAndAppendNimble(seuratObject = seuratObj, allowableGenomes = genomeId, targetAssayName = nimbleGenomes[[genomeId]], enforceUniqueFeatureNames = TRUE, dropAmbiguousFeatures = !retainAmbiguousFeatures, maxLibrarySizeRatio = maxLibrarySizeRatio)
1515
}
1616

1717
saveData(seuratObj, datasetId)

singlecell/src/org/labkey/singlecell/pipeline/singlecell/AppendNimble.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,11 @@ public Provider()
3535
SeuratToolParameter.create("retainAmbiguousFeatures", "Retain Ambiguous Features", "If checked, features hitting more than one reference will be retained", "checkbox", new JSONObject()
3636
{{
3737
put("check", false);
38-
}}, false, null, true)
38+
}}, false, null, true),
39+
SeuratToolParameter.create("maxLibrarySizeRatio", "Max Library Size Ratio", "This normalization relies on the assumption that the library size of the assay being normalized in negligible relative to the assayForLibrarySize. To verify this holds true, the method will error if librarySize(assayToNormalize)/librarySize(assayForLibrarySize) exceeds this value", "ldk-numberfield", new JSONObject()
40+
{{
41+
put("decimalPrecision", 4);
42+
}}, 0.1, null, true)
3943
), Arrays.asList("sequenceanalysis/field/GenomeField.js", "/singlecell/panel/NimbleAppendPanel.js"), null);
4044
}
4145

0 commit comments

Comments
 (0)