Skip to content

Commit f8ab5ea

Browse files
committed
Refactor getTotalVariantFeatures() method
1 parent 7ef0524 commit f8ab5ea

File tree

2 files changed

+19
-12
lines changed

2 files changed

+19
-12
lines changed

jbrowse/test/src/org/labkey/test/tests/external/labModules/JBrowseTest.java

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -299,18 +299,7 @@ private void testFilterWidget()
299299

300300
private long getTotalVariantFeatures()
301301
{
302-
Locator l = Locator.tagWithAttribute("svg", "data-testid", "svgfeatures").append(Locator.tag("polygon"));
303-
try
304-
{
305-
return Locator.findElements(getDriver(), l).stream().filter(WebElement::isDisplayed).count();
306-
}
307-
catch (StaleElementReferenceException e)
308-
{
309-
log("Stale elements, retrying");
310-
sleep(5000);
311-
312-
return Locator.findElements(getDriver(), l).stream().filter(WebElement::isDisplayed).count();
313-
}
302+
return JBrowseTestHelper.getTotalVariantFeatures(this);
314303
}
315304

316305
private void testLoadingConfigFilters(){

jbrowse/test/src/org/labkey/test/tests/external/labModules/JBrowseTestHelper.java

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
import org.labkey.test.util.ext4cmp.Ext4FieldRef;
1414
import org.labkey.test.util.ext4cmp.Ext4GridRef;
1515
import org.openqa.selenium.By;
16+
import org.openqa.selenium.StaleElementReferenceException;
17+
import org.openqa.selenium.WebElement;
1618

1719
import java.io.File;
1820
import java.util.stream.Collector;
@@ -145,4 +147,20 @@ public static void waitForJBrowseToLoad(BaseWebDriverTest test)
145147
test.waitForElementToDisappear(Locator.tagWithText("div", "Loading")); //track data
146148
test.waitForElementToDisappear(Locator.tagWithText("p", "Loading").withClass("MuiTypography-root")); // the track data
147149
}
150+
151+
public static long getTotalVariantFeatures(BaseWebDriverTest test)
152+
{
153+
Locator l = Locator.tagWithAttribute("svg", "data-testid", "svgfeatures").append(Locator.tag("polygon"));
154+
try
155+
{
156+
return Locator.findElements(test.getDriver(), l).stream().filter(WebElement::isDisplayed).count();
157+
}
158+
catch (StaleElementReferenceException e)
159+
{
160+
test.log("Stale elements, retrying");
161+
WebDriverWrapper.sleep(5000);
162+
163+
return Locator.findElements(test.getDriver(), l).stream().filter(WebElement::isDisplayed).count();
164+
}
165+
}
148166
}

0 commit comments

Comments
 (0)