Skip to content

Commit f897a57

Browse files
committed
Expose ability to keep ambiguous features with AppendNimble
1 parent 78424de commit f897a57

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

singlecell/resources/chunks/AppendNimble.R

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@ for (datasetId in names(seuratObjects)) {
1111
seuratObj <- readRDS(seuratObjects[[datasetId]])
1212

1313
for (genomeId in names(nimbleGenomes)) {
14-
#TODO: dropAmbiguousFeatures
15-
seuratObj <- Rdiscvr::DownloadAndAppendNimble(seuratObject = seuratObj, allowableGenomes = genomeId, targetAssayName = nimbleGenomes[[genomeId]], enforceUniqueFeatureNames = TRUE)
14+
seuratObj <- Rdiscvr::DownloadAndAppendNimble(seuratObject = seuratObj, allowableGenomes = genomeId, targetAssayName = nimbleGenomes[[genomeId]], enforceUniqueFeatureNames = TRUE, dropAmbiguousFeatures = !retainAmbiguousFeatures)
1615
}
1716

1817
saveData(seuratObj, datasetId)

singlecell/src/org/labkey/singlecell/pipeline/singlecell/AppendNimble.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,11 @@ public Provider()
3030
ToolParameterDescriptor.create("nimbleGenomes", "Genomes", "Genomes to include", "singlecell-nimbleappendpanel", new JSONObject()
3131
{{
3232
put("allowBlank", false);
33-
}}, null)
33+
}}, null),
34+
ToolParameterDescriptor.create("retainAmbiguousFeatures", "Retain Ambiguous Features", "If checked, features hitting more than one reference will be retained", "checkbox", new JSONObject()
35+
{{
36+
put("check", false);
37+
}}, false)
3438
), Arrays.asList("sequenceanalysis/field/GenomeField.js", "/singlecell/panel/NimbleAppendPanel.js"), null);
3539
}
3640

0 commit comments

Comments
 (0)