Skip to content

Commit f70bc46

Browse files
committed
Support more options for MarkDuplicates
1 parent f954e90 commit f70bc46

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

SequenceAnalysis/api-src/org/labkey/api/sequenceanalysis/run/PicardWrapper.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ protected List<String> getBaseArgs()
9696

9797
//note: having issues, probably due to OS versions
9898
params.add("USE_JDK_DEFLATER=true");
99-
params.add("USE_JDK_INFLATER=true");
10099

101100
return params;
102101
}

SequenceAnalysis/src/org/labkey/sequenceanalysis/run/bampostprocessing/MarkDuplicatesStep.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package org.labkey.sequenceanalysis.run.bampostprocessing;
22

3+
import org.json.JSONObject;
34
import org.labkey.api.pipeline.PipelineJobException;
45
import org.labkey.api.sequenceanalysis.model.Readset;
56
import org.labkey.api.sequenceanalysis.pipeline.BamProcessingOutputImpl;
@@ -35,7 +36,15 @@ public static class Provider extends AbstractPipelineStepProvider<MarkDuplicates
3536
public Provider()
3637
{
3738
super("MarkDuplicates", "Mark Duplicates", "Picard", "This runs Picard tools MarkDuplicates command in order to mark and/or remove duplicate reads. Please note this can have implications for downstream analysis, because reads marked as duplicates are frequently omitted. This is often desired, but can be a problem for sequencing of PCR products.", Arrays.asList(
38-
ToolParameterDescriptor.createCommandLineParam(CommandLineParam.create("REMOVE_DUPLICATES"), "removeDuplicates", "Remove Duplicates", "If selected, duplicate reads will be removed, as opposed to flagged as duplicates.", "checkbox", null, null)
39+
ToolParameterDescriptor.createCommandLineParam(CommandLineParam.create("REMOVE_DUPLICATES"), "removeDuplicates", "Remove Duplicates", "If selected, duplicate reads will be removed, as opposed to flagged as duplicates.", "checkbox", null, null),
40+
ToolParameterDescriptor.createCommandLineParam(CommandLineParam.create("MAX_RECORDS_IN_RAM"), "maxRecordsInRam", "Max Records in RAM", "When writing files that need to be sorted, this will specify the number of records stored in RAM before spilling to disk. Increasing this number reduces the number of file handles needed to sort the file, and increases the amount of RAM needed.", "ldk-integerfield", new JSONObject(){{
41+
put("minValue", 0);
42+
}}, null),
43+
ToolParameterDescriptor.createCommandLineParam(CommandLineParam.create("SORTING_COLLECTION_SIZE_RATIO "), "sortingCollectionSizeRatio", "Sorting Collection Size Ratio", "This number, plus the maximum RAM available to the JVM, determine the memory footprint used by some of the sorting collections. If you are running out of memory, try reducing this number. Default is 0.25", "ldk-numberfield", new JSONObject(){{
44+
put("minValue", 0);
45+
put("maxValue", 1);
46+
put("decimalPrecision", 2);
47+
}}, null)
3948
), null, "http://picard.sourceforge.net/command-line-overview.shtml");
4049
}
4150

0 commit comments

Comments
 (0)