Skip to content

Commit f500e83

Browse files
committed
Fix order in which seurat outputs are tagged
1 parent 0bcb100 commit f500e83

File tree

1 file changed

+15
-12
lines changed

1 file changed

+15
-12
lines changed

singlecell/src/org/labkey/singlecell/analysis/AbstractSingleCellHandler.java

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -478,21 +478,24 @@ else if (step.createsSeuratObjects())
478478

479479
_resumer.getFileManager().addStepOutputs(action, output);
480480

481-
if (output.getSeuratObjects() != null && !output.getSeuratObjects().isEmpty())
481+
if (step.createsSeuratObjects())
482482
{
483-
currentFiles = new ArrayList<>(output.getSeuratObjects());
484-
Set<File> possibleIntermediates = currentFiles.stream().map(SingleCellStep.SeuratObjectWrapper::getFile).collect(Collectors.toSet());
485-
possibleIntermediates.removeAll(originalInputs);
486-
if (!possibleIntermediates.isEmpty())
483+
if (output.getSeuratObjects() != null && !output.getSeuratObjects().isEmpty())
487484
{
488-
_resumer.getFileManager().addIntermediateFiles(possibleIntermediates);
489-
_resumer.getFileManager().addIntermediateFiles(possibleIntermediates.stream().map(x -> CellHashingServiceImpl.get().getCellBarcodesFromSeurat(x)).collect(Collectors.toSet()));
490-
_resumer.getFileManager().addIntermediateFiles(possibleIntermediates.stream().map(x -> CellHashingServiceImpl.get().getMetaTableFromSeurat(x)).collect(Collectors.toSet()));
485+
currentFiles = new ArrayList<>(output.getSeuratObjects());
486+
Set<File> possibleIntermediates = currentFiles.stream().map(SingleCellStep.SeuratObjectWrapper::getFile).collect(Collectors.toSet());
487+
possibleIntermediates.removeAll(originalInputs);
488+
if (!possibleIntermediates.isEmpty())
489+
{
490+
_resumer.getFileManager().addIntermediateFiles(possibleIntermediates);
491+
_resumer.getFileManager().addIntermediateFiles(possibleIntermediates.stream().map(x -> CellHashingServiceImpl.get().getCellBarcodesFromSeurat(x)).collect(Collectors.toSet()));
492+
_resumer.getFileManager().addIntermediateFiles(possibleIntermediates.stream().map(x -> CellHashingServiceImpl.get().getMetaTableFromSeurat(x)).collect(Collectors.toSet()));
493+
}
494+
}
495+
else
496+
{
497+
throw new PipelineJobException("Expected step to create seurat objects but none reported");
491498
}
492-
}
493-
else if (step.createsSeuratObjects())
494-
{
495-
throw new PipelineJobException("Expected step to create seurat objects but none reported");
496499
}
497500
else
498501
{

0 commit comments

Comments
 (0)