Fix field validation

bbimber · bbimber · commit eb7395486d85 · 2021-05-12T05:50:10.000-07:00
diff --git a/SequenceAnalysis/resources/web/SequenceAnalysis/field/TrimmingTextArea.js b/SequenceAnalysis/resources/web/SequenceAnalysis/field/TrimmingTextArea.js
@@ -22,7 +22,7 @@ Ext4.define('SequenceAnalysis.field.TrimmingTextArea', {
     getErrors: function(value){
         var errors = this.callParent(arguments);
 
-        if (!this.allowBlank && this.getSubmitValue() == null) {
+        if (!this.allowBlank && Ext4.isEmpty(this.getSubmitValue())) {
             errors = errors.concat('Must enter a value');
         }
 
diff --git a/SequenceAnalysis/src/org/labkey/sequenceanalysis/run/analysis/LofreqAnalysis.java b/SequenceAnalysis/src/org/labkey/sequenceanalysis/run/analysis/LofreqAnalysis.java
@@ -621,7 +621,7 @@ public Output performAnalysisPerSampleRemote(Readset rs, File inputBam, Referenc
                         continue;
                     }
 
-                    if (Double.parseDouble(line[6]) >= 0.5)
+                    if (Double.parseDouble(line[6]) >= 0.35)
                     {
                         indelMap.put(line[0], indelMap.getOrDefault(line[0], 0) + 1);
                     }

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ Ext4.define('SequenceAnalysis.field.TrimmingTextArea', {`
`22`	`22`	`getErrors: function(value){`
`23`	`23`	`var errors = this.callParent(arguments);`
`24`	`24`
`25`		`- if (!this.allowBlank && this.getSubmitValue() == null) {`
	`25`	`+ if (!this.allowBlank && Ext4.isEmpty(this.getSubmitValue())) {`
`26`	`26`	`errors = errors.concat('Must enter a value');`
`27`	`27`	`}`
`28`	`28`
Original file line number	Diff line number	Diff line change
`@@ -621,7 +621,7 @@ public Output performAnalysisPerSampleRemote(Readset rs, File inputBam, Referenc`
`621`	`621`	`continue;`
`622`	`622`	`}`
`623`	`623`
`624`		`- if (Double.parseDouble(line[6]) >= 0.5)`
	`624`	`+ if (Double.parseDouble(line[6]) >= 0.35)`
`625`	`625`	`{`
`626`	`626`	`indelMap.put(line[0], indelMap.getOrDefault(line[0], 0) + 1);`
`627`	`627`	`}`