Skip to content

Commit ea2c4ed

Browse files
committed
Barcoding bugfixes
1 parent 181c575 commit ea2c4ed

File tree

2 files changed

+6
-20
lines changed

2 files changed

+6
-20
lines changed

singlecell/src/org/labkey/singlecell/CellHashingServiceImpl.java

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -226,14 +226,7 @@ public void prepareHashingAndCiteSeqFilesIfNeeded(File sourceDir, PipelineJob jo
226226
TableSelector ts = new TableSelector(sequenceOutputs, filter, new org.labkey.api.data.Sort("-rowid"));
227227
if (!ts.exists())
228228
{
229-
if (failIfNoHashing)
230-
{
231-
throw new IllegalArgumentException("Unable to find existing count matrix for hashing readset: " + hashingReadsetId);
232-
}
233-
else
234-
{
235-
job.getLogger().info("Count matrix not found for readset: " + hashingReadsetId);
236-
}
229+
throw new IllegalArgumentException("Unable to find existing count matrix for hashing readset: " + hashingReadsetId);
237230
}
238231
else
239232
{
@@ -275,14 +268,7 @@ else if (distinctHTOs.size() == 1)
275268
TableSelector ts = new TableSelector(sequenceOutputs, filter, new org.labkey.api.data.Sort("-rowid"));
276269
if (!ts.exists())
277270
{
278-
if (failIfNoHashing)
279-
{
280-
throw new IllegalArgumentException("Unable to find existing count matrix for CITE-seq readset: " + citeseqReadsetId);
281-
}
282-
else
283-
{
284-
job.getLogger().info("Count matrix not found for readset: " + citeseqReadsetId);
285-
}
271+
throw new IllegalArgumentException("Unable to find existing count matrix for CITE-seq readset: " + citeseqReadsetId);
286272
}
287273
else
288274
{

singlecell/src/org/labkey/singlecell/run/CellRangerFeatureBarcodeHandler.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -167,9 +167,9 @@ else if (rs.getApplication().equals("CITE-Seq"))
167167

168168
//https://support.10xgenomics.com/single-cell-gene-expression/software/pipelines/latest/using/feature-bc-analysis
169169
File libraryCsv = new File(ctx.getOutputDir(), "libraries.csv");
170-
try (CSVWriter writer = new CSVWriter(PrintWriters.getPrintWriter(libraryCsv), ','))
170+
try (CSVWriter writer = new CSVWriter(PrintWriters.getPrintWriter(libraryCsv), ',', CSVWriter.NO_QUOTE_CHARACTER))
171171
{
172-
writer.writeNext(new String[]{"fastqs", "sample", "librarytype"});
172+
writer.writeNext(new String[]{"fastqs", "sample", "library_type"});
173173
writer.writeNext(new String[]{wrapper.getLocalFastqDir(ctx.getOutputDir()).getPath(), wrapper.makeLegalSampleName(rs.getName()), "Antibody Capture"});
174174
}
175175
catch (IOException e)
@@ -308,7 +308,7 @@ private File makeDummyIndex(JobContext ctx) throws PipelineJobException
308308
private File createFeatureRefForCiteSeq(File outputDir, File adtWhitelist) throws PipelineJobException
309309
{
310310
File featuresCsv = new File(outputDir, "adtFeatureRef.csv");
311-
try (CSVReader reader = new CSVReader(Readers.getReader(adtWhitelist), '\t'); CSVWriter writer = new CSVWriter(PrintWriters.getPrintWriter(featuresCsv), ','))
311+
try (CSVReader reader = new CSVReader(Readers.getReader(adtWhitelist), '\t'); CSVWriter writer = new CSVWriter(PrintWriters.getPrintWriter(featuresCsv), ',', CSVWriter.NO_QUOTE_CHARACTER))
312312
{
313313
writer.writeNext(new String[]{"id", "name", "read", "pattern", "sequence", "feature_type"});
314314

@@ -335,7 +335,7 @@ private File createFeatureRefForCiteSeq(File outputDir, File adtWhitelist) throw
335335
private File createFeatureRefForHashing(File outputDir, File hashingWhitelist) throws PipelineJobException
336336
{
337337
File featuresCsv = new File(outputDir, "hashingFeatureRef.csv");
338-
try (CSVReader reader = new CSVReader(Readers.getReader(hashingWhitelist), ',');CSVWriter writer = new CSVWriter(PrintWriters.getPrintWriter(featuresCsv), ','))
338+
try (CSVReader reader = new CSVReader(Readers.getReader(hashingWhitelist), ',');CSVWriter writer = new CSVWriter(PrintWriters.getPrintWriter(featuresCsv), ',', CSVWriter.NO_QUOTE_CHARACTER))
339339
{
340340
writer.writeNext(new String[]{"id", "name", "read", "pattern", "sequence", "feature_type"});
341341
String[] line;

0 commit comments

Comments
 (0)