Skip to content

Commit d1413b5

Browse files
committed
Bugfix to 10x lane assignment
1 parent c7f5b84 commit d1413b5

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

cluster/src/org/labkey/cluster/pipeline/SlurmExecutionEngine.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ protected Set<String> updateStatusForAllJobs() throws PipelineJobException
183183
String reason = reasonIdx != -1 && tokens.length > reasonIdx ? StringUtils.trimToNull(tokens[reasonIdx]) : null;
184184
if (reason != null)
185185
{
186-
if (!"Priority".equals(reason))
186+
if (!"Priority".equals(reason) && !"None".equals(reason))
187187
{
188188
if (status == null)
189189
{

singlecell/resources/web/singlecell/panel/LibraryExportPanel.js

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -839,6 +839,20 @@ Ext4.define('SingleCell.panel.LibraryExportPanel', {
839839
return;
840840
}
841841

842+
// The goal is to assign samples per lane, incrementing as we reach lane capacity
843+
if (totalData && autoAssignLane && !r.laneAssignment) {
844+
const dataAfterLane = dataInActiveLane + totalData;
845+
if (dataAfterLane > laneDataMax) {
846+
currentLane++;
847+
dataInActiveLane = totalData;
848+
}
849+
else {
850+
dataInActiveLane = dataAfterLane;
851+
}
852+
853+
r.laneAssignment = currentLane;
854+
}
855+
842856
barcodeCombosUsed.push([r[fieldName + '/barcode5'], r[fieldName + '/barcode3'], r.laneAssignment || ''].join('/'));
843857

844858
//The new format requires one/line
@@ -854,20 +868,6 @@ Ext4.define('SingleCell.panel.LibraryExportPanel', {
854868
//barcode5s = [barcode5s.join(',')];
855869
}
856870

857-
// The goal is to assign samples per lane, incrementing as we reach lane capacity
858-
if (totalData && autoAssignLane && !r.laneAssignment) {
859-
const dataAfterLane = dataInActiveLane + totalData;
860-
if (dataAfterLane > laneDataMax) {
861-
currentLane++;
862-
dataInActiveLane = totalData;
863-
}
864-
else {
865-
dataInActiveLane = dataAfterLane;
866-
}
867-
868-
r.laneAssignment = currentLane;
869-
}
870-
871871
Ext4.Array.forEach(barcode5s, function (bc, idx) {
872872
bc = doRC ? doReverseComplement(bc) : bc;
873873
const bc3 = barcode3s.length ? barcode3s[idx] : '';

0 commit comments

Comments
 (0)