Skip to content

Commit c871ecc

Browse files
committed
Bugfix feature barcoding
1 parent f038477 commit c871ecc

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

singlecell/src/org/labkey/singlecell/run/CellRangerFeatureBarcodeHandler.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ public void processFilesRemote(List<Readset> readsets, JobContext ctx) throws Un
143143
else if (rs.getApplication().equals("CITE-Seq"))
144144
{
145145
category = CITESEQ_CATEGORY;
146-
featureFile = createFeatureRefForCiteSeq(ctx.getOutputDir(), CellHashingServiceImpl.get().getValidCiteSeqBarcodeFile(ctx.getSourceDirectory(), rs.getReadsetId()));
146+
featureFile = createFeatureRefForCiteSeq(ctx.getOutputDir(), CellHashingServiceImpl.get().getValidCiteSeqBarcodeMetadataFile(ctx.getSourceDirectory(), rs.getReadsetId()));
147147
}
148148
else
149149
{
@@ -163,7 +163,7 @@ else if (rs.getApplication().equals("CITE-Seq"))
163163
inputFastqs.add(Pair.of(rd.getFile1(), rd.getFile2()));
164164
});
165165

166-
List<String> args = wrapper.prepareCountArgs(output, id, ctx.getOutputDir(), rs, inputFastqs, extraArgs);
166+
List<String> args = wrapper.prepareCountArgs(output, id, ctx.getOutputDir(), rs, inputFastqs, extraArgs, false);
167167

168168
//https://support.10xgenomics.com/single-cell-gene-expression/software/pipelines/latest/using/feature-bc-analysis
169169
File libraryCsv = new File(ctx.getOutputDir(), "libraries.csv");

singlecell/src/org/labkey/singlecell/run/CellRangerGexCountStep.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ public AlignmentOutput performAlignment(Readset rs, File inputFastq1, @Nullable
312312
});
313313
}
314314

315-
List<String> args = new ArrayList<>(getWrapper().prepareCountArgs(output, id, outputDirectory, rs, inputFastqs, getClientCommandArgs("=")));
315+
List<String> args = new ArrayList<>(getWrapper().prepareCountArgs(output, id, outputDirectory, rs, inputFastqs, getClientCommandArgs("="), true));
316316

317317
Integer gtfId = getProvider().getParameterByName("gtfFile").extractValue(getPipelineCtx().getJob(), getProvider(), getStepIdx(), Integer.class);
318318
File gtfFile = getPipelineCtx().getSequenceSupport().getCachedData(gtfId);

singlecell/src/org/labkey/singlecell/run/CellRangerWrapper.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public File getLocalFastqDir(File outputDirectory)
6767
return new File(outputDirectory, "localFq");
6868
}
6969

70-
public List<String> prepareCountArgs(AlignmentOutputImpl output, String id, File outputDirectory, Readset rs, List<Pair<File, File>> inputFastqPairs, List<String> extraArgs) throws PipelineJobException
70+
public List<String> prepareCountArgs(AlignmentOutputImpl output, String id, File outputDirectory, Readset rs, List<Pair<File, File>> inputFastqPairs, List<String> extraArgs, boolean writeFastqArgs) throws PipelineJobException
7171
{
7272
List<String> args = new ArrayList<>();
7373
args.add(getExe(false).getPath());
@@ -96,7 +96,10 @@ public List<String> prepareCountArgs(AlignmentOutputImpl output, String id, File
9696
output.addIntermediateFile(localFqDir);
9797

9898
Set<String> sampleNames = prepareFastqSymlinks(rs, localFqDir, inputFastqPairs);
99-
args.add("--fastqs=" + localFqDir.getPath());
99+
if (writeFastqArgs)
100+
{
101+
args.add("--fastqs=" + localFqDir.getPath());
102+
}
100103

101104
getLogger().debug("Sample names: [" + StringUtils.join(sampleNames, ",") + "]");
102105
if (sampleNames.size() > 1)

0 commit comments

Comments
 (0)