Skip to content

Commit bbebb14

Browse files
authored
Attempt to improve JBrowseTest (#129)
1 parent 537a5b4 commit bbebb14

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

jbrowse/test/src/org/labkey/test/tests/external/labModules/JBrowseTest.java

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
import org.labkey.test.util.external.labModules.LabModuleHelper;
4242
import org.openqa.selenium.By;
4343
import org.openqa.selenium.Keys;
44+
import org.openqa.selenium.StaleElementReferenceException;
4445
import org.openqa.selenium.WebElement;
4546
import org.openqa.selenium.interactions.Actions;
4647

@@ -243,7 +244,18 @@ private void testFilterWidget()
243244

244245
private long getTotalVariantFeatures()
245246
{
246-
return Locator.findElements(getDriver(), Locator.tagWithClass("svg", "SvgFeatureRendering").append(Locator.tag("polygon"))).stream().filter(WebElement::isDisplayed).count();
247+
Locator l = Locator.tagWithClass("svg", "SvgFeatureRendering").append(Locator.tag("polygon"));
248+
try
249+
{
250+
return Locator.findElements(getDriver(), l).stream().filter(WebElement::isDisplayed).count();
251+
}
252+
catch (StaleElementReferenceException e)
253+
{
254+
log("Stale elements, retrying");
255+
sleep(5000);
256+
257+
return Locator.findElements(getDriver(), l).stream().filter(WebElement::isDisplayed).count();
258+
}
247259
}
248260

249261
private void testLoadingConfigFilters(){
@@ -349,10 +361,8 @@ private Locator.XPathLocator getTrackLocator(String trackId, boolean waitFor)
349361
private By getVariantWithinTrack(String trackId, String variantText)
350362
{
351363
Locator.XPathLocator l = getTrackLocator(trackId, true);
352-
353-
l = l.append(Locator.xpath("//*[name()='text' and contains(text(), '" + variantText + "')]/..")).notHidden();
354-
355364
waitForElementToDisappear(Locator.tagWithText("p", "Loading"));
365+
l = l.append(Locator.xpath("//*[name()='text' and contains(text(), '" + variantText + "')]")).notHidden().append("/..");
356366
waitForElement(l);
357367

358368
return By.xpath(l.toXpath());

0 commit comments

Comments
 (0)