Skip to content

Commit abaee3d

Browse files
committed
Support ensureSamplesShareAllGenomes for AppendNimble
1 parent c181b87 commit abaee3d

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

singlecell/resources/chunks/AppendNimble.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ for (datasetId in names(seuratObjects)) {
1111
seuratObj <- readSeuratRDS(seuratObjects[[datasetId]])
1212

1313
for (genomeId in names(nimbleGenomes)) {
14-
seuratObj <- Rdiscvr::DownloadAndAppendNimble(seuratObject = seuratObj, allowableGenomes = genomeId, targetAssayName = nimbleGenomes[[genomeId]], enforceUniqueFeatureNames = TRUE, dropAmbiguousFeatures = !retainAmbiguousFeatures, maxLibrarySizeRatio = maxLibrarySizeRatio)
14+
seuratObj <- Rdiscvr::DownloadAndAppendNimble(seuratObject = seuratObj, allowableGenomes = genomeId, ensureSamplesShareAllGenomes = ensureSamplesShareAllGenomes, targetAssayName = nimbleGenomes[[genomeId]], enforceUniqueFeatureNames = TRUE, dropAmbiguousFeatures = !retainAmbiguousFeatures, maxLibrarySizeRatio = maxLibrarySizeRatio)
1515
}
1616

1717
saveData(seuratObj, datasetId)

singlecell/src/org/labkey/singlecell/pipeline/singlecell/AppendNimble.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,10 @@ public Provider()
3636
{{
3737
put("check", false);
3838
}}, false, null, true),
39+
SeuratToolParameter.create("ensureSamplesShareAllGenomes", "Ensure Samples Share All Genomes", "If checked, the job will fail unless nimble data is found for each requested genome for all samples", "checkbox", new JSONObject()
40+
{{
41+
put("check", true);
42+
}}, true, null, true),
3943
SeuratToolParameter.create("maxLibrarySizeRatio", "Max Library Size Ratio", "This normalization relies on the assumption that the library size of the assay being normalized in negligible relative to the assayForLibrarySize. To verify this holds true, the method will error if librarySize(assayToNormalize)/librarySize(assayForLibrarySize) exceeds this value", "ldk-numberfield", new JSONObject()
4044
{{
4145
put("decimalPrecision", 4);

0 commit comments

Comments
 (0)