Favor DataRegion getChecked over getSelected

Author: bbimber

SequenceAnalysis/resources/web/SequenceAnalysis/window/AddFileSetsWindow.js

@@ -8,28 +8,18 @@ Ext4.define('SequenceAnalysis.window.AddFileSetsWindow', {
 
     statics: {
         buttonHandlerForOutputFiles: function(dataRegionName){
-            var dr = LABKEY.DataRegions[dataRegionName];
-            Ext4.Msg.wait('Loading...');
-            dr.getSelected({
-                scope: this,
-                success: function(results, response) {
-                    Ext4.Msg.hide();
-
-                    if (!results || !results.selected || !results.selected.length) {
-                        Ext4.Msg.alert('Error', 'No rows selected');
-                        return;
-                    }
+            var checked = LABKEY.DataRegions[dataRegionName].getChecked();
+            if (!checked.length) {
+                Ext4.Msg.alert('Error', 'No rows selected');
+                return;
+            }
 
-                    var checked = LABKEY.DataRegions[dataRegionName].getChecked();
-                    Ext4.create('SequenceAnalysis.window.AddFileSetsWindow', {
-                        targetTable: 'outputfiles',
-                        targetField: 'outputFileId',
-                        dataRegionName: dataRegionName,
-                        pks: checked
-                    }).show();
-                },
-                failure: LDK.Utils.getErrorCallback()
-            });
+            Ext4.create('SequenceAnalysis.window.AddFileSetsWindow', {
+                targetTable: 'outputfiles',
+                targetField: 'outputFileId',
+                dataRegionName: dataRegionName,
+                pks: checked
+            }).show();
         }
     },
 

SequenceAnalysis/resources/web/SequenceAnalysis/window/VisualizeDataWindow.js

@@ -2,40 +2,32 @@ Ext4.define('SequenceAnalysis.window.VisualizeDataWindow', {
     extend: 'Ext.window.Window',
     statics: {
         buttonHandler: function(dataRegionName){
-            var dataRegion = LABKEY.DataRegions[dataRegionName];
-            dataRegion.getSelected({
-                scope: this,
-                success: function (results, response) {
-                    if (!results || !results.selected || !results.selected.length) {
-                        Ext4.Msg.alert('Error', 'No rows selected');
-                        return;
-                    }
-
-                    var checked = LABKEY.DataRegions[dataRegionName].getChecked();
-
-                    Ext4.Msg.wait('Loading...');
-                    LABKEY.Ajax.request({
-                        method: 'POST',
-                        url: LABKEY.ActionURL.buildURL('sequenceanalysis', 'getAvailableHandlers', null),
-                        params: {
-                            handlerType: 'OutputFile',
-                            outputFileIds: checked
-                        },
-                        scope: this,
-                        failure: LDK.Utils.getErrorCallback(),
-                        success: LABKEY.Utils.getCallbackWrapper(function (results) {
-                            Ext4.Msg.hide();
-
-                            Ext4.create('SequenceAnalysis.window.VisualizeDataWindow', {
-                                dataRegionName: dataRegionName,
-                                handlers: results.handlers,
-                                partialHandlers: results.partialHandlers,
-                                outputFileIds: checked
-                            }).show();
-                        }, this)
-                    });
+            var checked = LABKEY.DataRegions[dataRegionName].getChecked();
+            if (!checked.length) {
+                Ext4.Msg.alert('Error', 'No rows selected');
+                return;
+            }
+
+            Ext4.Msg.wait('Loading...');
+            LABKEY.Ajax.request({
+                method: 'POST',
+                url: LABKEY.ActionURL.buildURL('sequenceanalysis', 'getAvailableHandlers', null),
+                params: {
+                    handlerType: 'OutputFile',
+                    outputFileIds: checked
                 },
-                failure: LDK.Utils.getErrorCallback()
+                scope: this,
+                failure: LDK.Utils.getErrorCallback(),
+                success: LABKEY.Utils.getCallbackWrapper(function (results) {
+                    Ext4.Msg.hide();
+
+                    Ext4.create('SequenceAnalysis.window.VisualizeDataWindow', {
+                        dataRegionName: dataRegionName,
+                        handlers: results.handlers,
+                        partialHandlers: results.partialHandlers,
+                        outputFileIds: checked
+                    }).show();
+                }, this)
             });
         }
     },