Prevent redundant job submissions

Author: bbimber

SequenceAnalysis/build.gradle

@@ -90,7 +90,7 @@ dependencies {
    BuildUtils.addExternalDependency(
            project,
            new ExternalDependency(
-                   "com.github.broadinstitute:picard:2.22.4",
+                   "com.github.broadinstitute:picard:2.26.10",
                    "Picard Tools Lib",
                    "PicardTools",
                    "https://github.com/broadinstitute/picard",

cluster/src/org/labkey/cluster/ClusterController.java

@@ -49,9 +49,12 @@
 
 import java.io.File;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.HashMap;
+import java.util.HashSet;
 import java.util.List;
 import java.util.Map;
+import java.util.Set;
 
 public class ClusterController extends SpringActionController
 {
@@ -127,8 +130,9 @@ public boolean handlePost(JobIdsForm form, BindException errors) throws Exceptio
                 return false;
             }
 
+            Set<String> jobs = new HashSet<>(Arrays.asList(jobIDs.split(",")));
             List<PipelineStatusFile> sfs = new ArrayList<>();
-            for (String id : jobIDs.split(","))
+            for (String id : jobs)
             {
                 int jobId = Integer.parseInt(StringUtils.trimToNull(id));
                 PipelineStatusFile sf = PipelineService.get().getStatusFile(jobId);
@@ -277,7 +281,7 @@ public ModelAndView getConfirmView(JobIdsForm form, BindException errors) throws
         {
             return new HtmlView(HtmlString.unsafe("This will attempt to re-queue existing pipeline jobs using their serialized JSON text files.  It is intended as a workaround for the situation where a job has been marked complete." +
                     "To continue, enter a comma-delimited list of Job IDs and hit submit:<br><br>" +
-                    "<label>Enter Job ID(s): </label><input name=\"jobIds\" value=\"" + form.getJobIds() + "\"><br>"));
+                    "<label>Enter Job ID(s): </label><input name=\"jobIds\" value=\"" + HtmlString.of(form.getJobIds()) + "\"><br>"));
         }
 
         public boolean handlePost(JobIdsForm form, BindException errors) throws Exception
@@ -289,8 +293,9 @@ public boolean handlePost(JobIdsForm form, BindException errors) throws Exceptio
                 return false;
             }
 
+            Set<String> jobs = new HashSet<>(Arrays.asList(jobIDs.split(",")));
             List<PipelineStatusFile> sfs = new ArrayList<>();
-            for (String id : jobIDs.split(","))
+            for (String id : jobs)
             {
                 int jobId = Integer.parseInt(StringUtils.trimToNull(id));
                 PipelineStatusFile sf = PipelineService.get().getStatusFile(jobId);