Skip to content

Commit 79ebded

Browse files
committed
Small improvements to 10x library import
1 parent faa57de commit 79ebded

File tree

2 files changed

+27
-11
lines changed

2 files changed

+27
-11
lines changed

singlecell/resources/web/singlecell/panel/LibraryExportPanel.js

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,12 @@ Ext4.define('SingleCell.panel.LibraryExportPanel', {
4949
editable: false,
5050
labelWidth: 160,
5151
storeValues: ['NextSeq (MPSSR)', 'MiSeq (ONPRC)', 'Basic List (MedGenome)', '10x Sample Sheet', 'Novogene', 'Novogene-New']
52+
},{
53+
xtype: 'textfield',
54+
itemId: 'hashingPrefix',
55+
fieldLabel: 'Hashing Library Prefix',
56+
labelWidth: 160,
57+
value: 'H'
5258
},{
5359
xtype: 'ldk-simplecombo',
5460
itemId: 'application',
@@ -535,15 +541,16 @@ Ext4.define('SingleCell.panel.LibraryExportPanel', {
535541

536542
plateIds = Ext4.unique(plateIds);
537543

538-
var instrument = btn.up('singlecell-libraryexportpanel').down('#instrument').getValue();
539-
var application = btn.up('singlecell-libraryexportpanel').down('#application') ? btn.up('singlecell-libraryexportpanel').down('#application').getValue() : null;
540-
var defaultVolume = btn.up('singlecell-libraryexportpanel').down('#defaultVolume') ? btn.up('singlecell-libraryexportpanel').down('#defaultVolume').getValue() : '';
541-
var adapter = btn.up('singlecell-libraryexportpanel').down('#adapter') ? btn.up('singlecell-libraryexportpanel').down('#adapter').getValue() : null;
542-
var includeWithData = btn.up('singlecell-libraryexportpanel').down('#includeWithData').getValue();
543-
var allowDuplicates = btn.up('singlecell-libraryexportpanel').down('#allowDuplicates').getValue();
544-
var simpleSampleNames = btn.up('singlecell-libraryexportpanel').down('#simpleSampleNames').getValue();
545-
var includeBlanks = btn.up('singlecell-libraryexportpanel').down('#includeBlanks').getValue();
546-
var doReverseComplement = btn.up('singlecell-libraryexportpanel').doReverseComplement;
544+
const instrument = btn.up('singlecell-libraryexportpanel').down('#instrument').getValue();
545+
const application = btn.up('singlecell-libraryexportpanel').down('#application') ? btn.up('singlecell-libraryexportpanel').down('#application').getValue() : null;
546+
const defaultVolume = btn.up('singlecell-libraryexportpanel').down('#defaultVolume') ? btn.up('singlecell-libraryexportpanel').down('#defaultVolume').getValue() : '';
547+
const adapter = btn.up('singlecell-libraryexportpanel').down('#adapter') ? btn.up('singlecell-libraryexportpanel').down('#adapter').getValue() : null;
548+
const includeWithData = btn.up('singlecell-libraryexportpanel').down('#includeWithData').getValue();
549+
const allowDuplicates = btn.up('singlecell-libraryexportpanel').down('#allowDuplicates').getValue();
550+
const simpleSampleNames = btn.up('singlecell-libraryexportpanel').down('#simpleSampleNames').getValue();
551+
const includeBlanks = btn.up('singlecell-libraryexportpanel').down('#includeBlanks').getValue();
552+
const doReverseComplement = btn.up('singlecell-libraryexportpanel').doReverseComplement;
553+
const hashingPrefix = btn.up('singlecell-libraryexportpanel').down('#hashingPrefix').getValue();
547554

548555
var isMatchingApplication = function(application, libraryType, readsetApplication, rowLevelApplication){
549556
if (!application && !rowLevelApplication){
@@ -891,7 +898,7 @@ Ext4.define('SingleCell.panel.LibraryExportPanel', {
891898

892899
// NOTE: Dual index 10x is always presented in the right orientation, so only RC if single-indexed
893900
const hashingDoRC = !r['hashingReadsetId/barcode3'];
894-
processType(readsetIds, rows, r, 'hashingReadsetId', 'HTO', 182, 0.05, 'H', 'Cell hashing, 190bp amplicon. Please QC individually and pool in equal amounts per lane', hashingDoRC, 20, runMap, totalCells);
901+
processType(readsetIds, rows, r, 'hashingReadsetId', 'HTO', 182, 0.05, hashingPrefix, 'Cell hashing, 190bp amplicon. Please QC individually and pool in equal amounts per lane', hashingDoRC, 20, runMap, totalCells);
895902
processType(readsetIds, rows, r, 'citeseqReadsetId', 'CITE', 182, 0.05, 'C', 'CITE-Seq, 190bp amplicon. Please QC individually and pool in equal amounts per lane', false, 20, runMap, totalCells);
896903
}, this);
897904

singlecell/resources/web/singlecell/panel/PoolImportPanel.js

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,10 @@ Ext4.define('SingleCell.panel.PoolImportPanel', {
222222
if (val && (val.toLowerCase() === 'no' || val.toLowerCase() === 'n')) {
223223
return null;
224224
}
225+
else if (val && (val.toLowerCase() === 'yes' || val.toLowerCase() === 'y')) {
226+
var panel = panel.down('#defaultCiteSeqPanel').getValue();
227+
return panel || val;
228+
}
225229

226230
return val;
227231
},
@@ -498,13 +502,18 @@ Ext4.define('SingleCell.panel.PoolImportPanel', {
498502
checked: true,
499503
listeners: {
500504
scope: this,
501-
change: function(field, val) {
505+
change: function (field, val) {
502506
field.up('panel').down('#requireGEX').setValue(!val);
503507
field.up('panel').down('#requireTCR').setValue(!val);
504508
field.up('panel').down('#requireHTO').setValue(!val);
505509
field.up('panel').down('#requireCITE').setValue(!val);
506510
}
507511
}
512+
},{
513+
xtype: 'textfield',
514+
itemId: 'defaultCiteSeqPanel',
515+
fieldLabel: 'Default CITE-seq Panel',
516+
value: 'TB-V2'
508517
},{
509518
xtype: 'checkbox',
510519
fieldLabel: 'Use 10x V2/HT (Dual Index)',

0 commit comments

Comments
 (0)