Skip to content

Commit 78a2cf4

Browse files
committed
Fix sql scripts, add natural sorting
1 parent 29d2bd2 commit 78a2cf4

File tree

7 files changed

+18
-9
lines changed

7 files changed

+18
-9
lines changed

singlecell/resources/schemas/dbscripts/postgresql/singlecell-20.002-20.003.sql

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ CREATE TABLE singlecell.hashing_labels (
22
rowid serial,
33
name varchar(100),
44
groupName varchar(100),
5-
markerLabel varchar(100),
65
adaptersequence varchar(4000),
76
barcodePattern varchar(100),
87

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
;

singlecell/resources/schemas/dbscripts/sqlserver/singlecell-20.002-20.003.sql

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ CREATE TABLE singlecell.hashing_labels (
22
rowid int IDENTITY(1,1),
33
name nvarchar(100),
44
groupName nvarchar(100),
5-
markerLabel nvarchar(100),
65
adaptersequence nvarchar(4000),
76
barcodePattern nvarchar(100),
87

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
--Accidentally deployed:
2+
EXEC core.fn_dropifexists 'hashing_labels', 'singlecell', 'COLUMN', 'markerLabel';

singlecell/src/org/labkey/singlecell/CellHashingServiceImpl.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ public void prepareHashingAndCiteSeqFilesIfNeeded(File sourceDir, PipelineJob jo
110110
FieldKey.fromString("sortId/sampleId/stim"),
111111
FieldKey.fromString("sortId/population"),
112112
FieldKey.fromString("sortId/hto"),
113-
FieldKey.fromString("sortId/hto/sequence"),
113+
FieldKey.fromString("sortId/hto/adaptersequence"),
114114
FieldKey.fromString("hashingReadsetId"),
115115
FieldKey.fromString("hashingReadsetId/totalFiles"),
116116
FieldKey.fromString("citeseqReadsetId"),
@@ -153,7 +153,7 @@ public void prepareHashingAndCiteSeqFilesIfNeeded(File sourceDir, PipelineJob jo
153153
String.valueOf(results.getObject(FieldKey.fromString("hashingReadsetId")) == null ? "" : results.getInt(FieldKey.fromString("hashingReadsetId"))),
154154
String.valueOf(results.getObject(FieldKey.fromString("hashingReadsetId/totalFiles")) != null && results.getInt(FieldKey.fromString("hashingReadsetId/totalFiles")) > 0),
155155
results.getString(FieldKey.fromString("sortId/hto")),
156-
results.getString(FieldKey.fromString("sortId/hto/sequence")),
156+
results.getString(FieldKey.fromString("sortId/hto/adaptersequence")),
157157
String.valueOf(results.getObject(FieldKey.fromString("citeseqReadsetId")) == null ? "" : results.getInt(FieldKey.fromString("citeseqReadsetId"))),
158158
String.valueOf(results.getObject(FieldKey.fromString("citeseqReadsetId/totalFiles")) != null && results.getInt(FieldKey.fromString("citeseqReadsetId/totalFiles")) > 0),
159159
results.getString(FieldKey.fromString("citeseqPanel"))
@@ -173,14 +173,14 @@ public void prepareHashingAndCiteSeqFilesIfNeeded(File sourceDir, PipelineJob jo
173173
{
174174
readsetToHashingMap.put(rs.getReadsetId(), results.getInt(FieldKey.fromString("hashingReadsetId")));
175175

176-
String hto = results.getString(FieldKey.fromString("sortId/hto")) + "<>" + results.getString(FieldKey.fromString("sortId/hto/sequence"));
177-
if (!distinctHTOs.contains(hto) && !StringUtils.isEmpty(results.getString(FieldKey.fromString("sortId/hto/sequence"))))
176+
String hto = results.getString(FieldKey.fromString("sortId/hto")) + "<>" + results.getString(FieldKey.fromString("sortId/hto/adaptersequence"));
177+
if (!distinctHTOs.contains(hto) && !StringUtils.isEmpty(results.getString(FieldKey.fromString("sortId/hto/adaptersequence"))))
178178
{
179179
distinctHTOs.add(hto);
180-
bcWriter.writeNext(new String[]{results.getString(FieldKey.fromString("sortId/hto/sequence")), results.getString(FieldKey.fromString("sortId/hto"))});
180+
bcWriter.writeNext(new String[]{results.getString(FieldKey.fromString("sortId/hto/adaptersequence")), results.getString(FieldKey.fromString("sortId/hto"))});
181181
}
182182

183-
if (results.getObject(FieldKey.fromString("sortId/hto/sequence")) == null)
183+
if (results.getObject(FieldKey.fromString("sortId/hto/adaptersequence")) == null)
184184
{
185185
job.getLogger().error("Unable to find sequence for HTO: " + results.getString(FieldKey.fromString("sortId/hto")));
186186
hasError.set(true);

singlecell/src/org/labkey/singlecell/SingleCellModule.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public String getName()
5757
@Override
5858
public @Nullable Double getSchemaVersion()
5959
{
60-
return 20.003;
60+
return 20.004;
6161
}
6262

6363
@Override

singlecell/src/org/labkey/singlecell/SingleCellTableCustomizer.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,14 @@ else if (matches(ti, SingleCellSchema.NAME, SingleCellSchema.TABLE_CDNAS))
3636
{
3737
customizeCdnas(ti);
3838
}
39+
else if (matches(ti, SingleCellSchema.NAME, SingleCellSchema.TABLE_HASHING_LABELS))
40+
{
41+
LDKService.get().applyNaturalSort(ti, "name");
42+
}
43+
else if (matches(ti, SingleCellSchema.NAME, SingleCellSchema.TABLE_CITE_SEQ_ANTIBODIES))
44+
{
45+
LDKService.get().applyNaturalSort(ti, "antibodyName");
46+
}
3947
}
4048
}
4149

0 commit comments

Comments
 (0)